Source/core/dom/Text.cpp - Issue 23628004: Tables with display:inline rendered in wrong position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Text.cpp

Issue 23628004: Tables with display:inline rendered in wrong position. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Creating inline table during render tree construction Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/fast/table/table-display-inline-expected.txt ('k') | Source/core/rendering/RenderInline.cpp » ('j') | Source/core/rendering/RenderInline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Text.cpp

diff --git a/Source/core/dom/Text.cpp b/Source/core/dom/Text.cpp

index 7a39eda580c161b4ca53126f8d575f2e416eb46d..68326d2b6c2feb9858ae45065b646278385983ab 100644

--- a/Source/core/dom/Text.cpp

+++ b/Source/core/dom/Text.cpp

@@ -219,6 +219,8 @@ bool Text::textRendererIsNeeded(const NodeRenderingContext& context)

// <span><div/> <div/></span>

if (prev && !prev->isInline())

return false;

+ else if (parent->isTableTag())

+ return false;

} else {

if (parent->isRenderBlock() && !parent->childrenInline() && (!prev || !prev->isInline()))

return false;