Wait for async file creation in TabsTest

Wait for async file creation in TabsTest

File creation of tab states is done in an async fashion.
TabsTest should correspondingly use a polling mechanism
to verify files are actually being created.

BUG=649429
Committed: https://crrev.com/60fb2a58f8d53e033f22722c5b41142de7a733b9
Cr-Commit-Position: refs/heads/master@{#420628}

[kraush, 2016-09-22 18:45:59]

kraush@amazon.com changed reviewers:
+ tedchoc@chromium.org

[kraush, 2016-09-22 18:45:59]

Hi Ted,

Can you take a look at this test fix for slower devices?

Thanks! :)
Holger

[Ted C, 2016-09-22 20:29:17]

lgtm

https://codereview.chromium.org/2362793002/diff/1/chrome/android/javatests/sr...
File chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
(right):

https://codereview.chromium.org/2362793002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java:1729: new
Criteria("Unexpected file status: " + fileToCheck.getAbsolutePath()) {
for equality checks, I prefer using Criteria.equals

        Criteria.equals(expected, new Callable<Boolean>() {
            @Override
            public Boolean call() {
                return fileToCheck.exists();
            }
        })

It will get a more standard error message that way.

[kraush, 2016-09-22 20:34:44]

On 2016/09/22 20:29:17, Ted C wrote:
> lgtm
> 
>
https://codereview.chromium.org/2362793002/diff/1/chrome/android/javatests/sr...
> File chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
> (right):
> 
>
https://codereview.chromium.org/2362793002/diff/1/chrome/android/javatests/sr...
> chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java:1729:
new
> Criteria("Unexpected file status: " + fileToCheck.getAbsolutePath()) {
> for equality checks, I prefer using Criteria.equals
> 
>         Criteria.equals(expected, new Callable<Boolean>() {
>             @Override
>             public Boolean call() {
>                 return fileToCheck.exists();
>             }
>         })
> 
> It will get a more standard error message that way.

Nice, I hadn't used that syntax before, thanks Ted! :)
I'll update it and commit the second diff.

[kraush, 2016-09-23 15:02:06]

Using Criteria.equals
(Sorry for the delay)

[kraush, 2016-09-23 15:02:24]

The CQ bit was checked by kraush@amazon.com

[kraush, 2016-09-23 15:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2362793002/#ps20001
(title: "Switched to Criteria.equals")

[commit-bot: I haz the power, 2016-09-23 15:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:35:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 16:37:44]

Description was changed from

==========
Wait for async file creation in TabsTest

File creation of tab states is done in an async fashion.
TabsTest should correspondingly use a polling mechanism
to verify files are actually being created.

BUG=649429
==========

to

==========
Wait for async file creation in TabsTest

File creation of tab states is done in an async fashion.
TabsTest should correspondingly use a polling mechanism
to verify files are actually being created.

BUG=649429

Committed: https://crrev.com/60fb2a58f8d53e033f22722c5b41142de7a733b9
Cr-Commit-Position: refs/heads/master@{#420628}
==========

[commit-bot: I haz the power, 2016-09-23 16:37:44]

Patchset 2 (id:??) landed as
https://crrev.com/60fb2a58f8d53e033f22722c5b41142de7a733b9
Cr-Commit-Position: refs/heads/master@{#420628}