[swarming/api] Add text in to indicate whether a shard is failing

scripts/slave/recipe_modules/swarming/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import functools
 
 from recipe_engine import recipe_api
 
 
@@ skipping 766 matching lines @@
       # recipe_api.StepFailure exception from the collect step above. Instead
       # it is being allowed to propagate after the results have been parsed.
       try:
         step_result = self.m.step.active_result
         outdir_json = self.m.json.dumps(step_result.raw_io.output_dir, indent=2)
         step_result.presentation.logs['outdir_json'] = outdir_json.splitlines()
 
         # Check if it's an internal failure.
         summary = self.m.json.loads(
             step_result.raw_io.output_dir['summary.json'])
-        if any(shard['internal_failure'] for shard in summary['shards']):
+        if any(not shard or shard['internal_failure']
+               for shard in summary['shards']):
           raise recipe_api.InfraFailure('Internal swarming failure.')
 
         # Always show the shards' links in the collect step. (It looks
         # like show_isolated_out_in_collect_step is false by default
         # in recipe runs.)
         links = step_result.presentation.links
         for index in xrange(task.shards):
           url = task.get_shard_view_url(index)
+          if summary['shards'][index].get('exit_code', None) != 0:
+            display_text = 'shard #%d (failed)' % index
+          else:
+            display_text = 'shard #%d' % index

[nednguyen, 2016/09/22 21:47:07]

Now I am missing test coverage at this line because all the summary results in
test doesn't contain exit_code. Anyone knows how to modify the summary output
for the expectation tests?

           if url:
-            links['shard #%d' % index] = url
+            links[display_text] = url
 
         step_result.isolated_script_results = \
           self._merge_isolated_script_shards(task, step_result)
 
         self._display_pending(summary, step_result.presentation)
       except Exception as e:
         self.m.step.active_result.presentation.logs['no_results_exc'] = [str(e)]
         self.m.step.active_result.isolated_script_results = None
 
   def _get_step_name(self, prefix, task):
@@ skipping 181 matching lines @@
 
   def get_shard_view_url(self, index):
     """Returns URL of HTML page with shard details or None if not available.
 
     Works only after the task has been successfully triggered.
     """
     if self._trigger_output and self._trigger_output.get('tasks'):
       for shard_dict in self._trigger_output['tasks'].itervalues():
         if shard_dict['shard_index'] == index:
           return shard_dict['view_url']