[swarming/api] Add text in to indicate whether a shard is failing

scripts/slave/recipe_modules/swarming/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import functools
 
 from recipe_engine import recipe_api
 
 
@@ skipping 775 matching lines @@
             step_result.raw_io.output_dir['summary.json'])
         if any(shard['internal_failure'] for shard in summary['shards']):
           raise recipe_api.InfraFailure('Internal swarming failure.')
 
         # Always show the shards' links in the collect step. (It looks
         # like show_isolated_out_in_collect_step is false by default
         # in recipe runs.)
         links = step_result.presentation.links
         for index in xrange(task.shards):
           url = task.get_shard_view_url(index)
+          if summary['shards'][index] is None:
+            display_text = 'shard #%d (failed - result not received)' % index

[M-A Ruel, 2016/09/22 21:09:19]

We should treat that as an infrastructure failure (while at it).

[nednguyen, 2016/09/22 21:46:03]

Done.

+          elif summary['shards'][index].get('exit_code', 0) != 0:

[M-A Ruel, 2016/09/22 21:09:19]

, None)

since if it's missing this is bad.

[nednguyen, 2016/09/22 21:46:03]

Done.

+            display_text = 'shard #%d (failed)' % index
+          else:
+            display_text = 'shard #%d' % index
           if url:
-            links['shard #%d' % index] = url
+            links[display_text] = url
 
         step_result.isolated_script_results = \
           self._merge_isolated_script_shards(task, step_result)
 
         self._display_pending(summary, step_result.presentation)
       except Exception as e:
         self.m.step.active_result.presentation.logs['no_results_exc'] = [str(e)]
         self.m.step.active_result.isolated_script_results = None
 
   def _get_step_name(self, prefix, task):
@@ skipping 181 matching lines @@
 
   def get_shard_view_url(self, index):
     """Returns URL of HTML page with shard details or None if not available.
 
     Works only after the task has been successfully triggered.
     """
     if self._trigger_output and self._trigger_output.get('tasks'):
       for shard_dict in self._trigger_output['tasks'].itervalues():
         if shard_dict['shard_index'] == index:
           return shard_dict['view_url']