Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 2362693004: Revert "Remove window.postMessage(message, transferables, targetOrigin) legacy overload" (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "Remove window.postMessage(message, transferables, targetOrigin) legacy overload" This reverts commits a91dd1d7611e879f8d03bf533c45fa229ed7246d and 48caa2cebaf1723dcfd8665e4859d90e2b55f2a2. In addition: * Update the deprecation message for M55 removal. * Exclude changes to postMessage calls outside of tests, as those might otherwise trigger the deprecation message. BUG=425896, 649157 TBR=sigbjornf@opera.com,haraken@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +18 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362693004/1
4 years, 3 months ago (2016-09-23 09:50:58 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-23 09:51:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362693004/1
4 years, 3 months ago (2016-09-23 09:53:56 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 11:25:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698