chrome/android/java/res/layout/search_engine_layout.xml - Issue 2362673005: [Android] Change default search engine setting page to full screen

Side by Side Diff: chrome/android/java/res/layout/search_engine_layout.xml

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/android/java/res/layout/custom_preference.xml ('K') | « chrome/android/java/res/layout/search_engine.xml ('k') | chrome/android/java/res/xml/main_preferences.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:paddingTop="6dp"

	12 android:paddingBottom="6dp"

	13 android:orientation="vertical">
	Ian Wen 2016/09/23 20:43:24 Add space here Add space here ltian 2016/09/23 21:32:05 Done. Show quoted text On 2016/09/23 20:43:24, Ian Wen wrote: > Add space here Done.
	14 <ListView

	15 android:id="@android:id/list"

	16 android:layout_width="match_parent"

	17 android:layout_height="0dp"

	18 android:layout_weight="1"/>

	19

	20 <View

	21 android:id="@+id/bottombar_shadow"
	Ian Wen 2016/09/23 20:43:24 You should have a top margin that is -4dp, so that You should have a top margin that is -4dp, so that the shadow can show upon the listview, without taking space. You should also upload a screenshot to the bug. ltian 2016/09/23 21:32:05 Done. Show quoted text On 2016/09/23 20:43:24, Ian Wen wrote: > You should have a top margin that is -4dp, so that the shadow can show upon the > listview, without taking space. > > You should also upload a screenshot to the bug. Done.
	22 android:layout_width="match_parent"

	23 android:layout_height="4dp"

	24 android:background="@drawable/toolbar_shadow_normal"

	25 android:scaleY="-1" />
	Ian Wen 2016/09/23 20:43:25 Add spaced here. Add spaced here. ltian 2016/09/23 21:32:05 Done. Show quoted text On 2016/09/23 20:43:25, Ian Wen wrote: > Add spaced here. Done.
	26 <LinearLayout

	27 android:layout_width="match_parent"

	28 android:layout_height="56dp"

	29 android:layout_marginTop="-4dp"

	30 android:orientation="horizontal"

	31 android:gravity="end"

	32 android:paddingStart="6dp"

	33 android:paddingEnd="6dp">

	34 <Button

	35 android:id="@+id/cancel_button"

	36 style="@style/ButtonCompatBorderless"

	37 android:layout_width="wrap_content"

	38 android:layout_height="wrap_content"

	39 android:textColor="@color/light_active_color"

	40 android:text="@string/cancel"

	41 android:textAllCaps="true"

	42 android:textSize="16sp"

	43 android:layout_marginEnd="16dp"

	44 android:layout_gravity="center_vertical"/>
	Ian Wen 2016/09/23 20:43:24 Space here as well Space here as well ltian 2016/09/23 21:32:05 Done. Show quoted text On 2016/09/23 20:43:24, Ian Wen wrote: > Space here as well Done.
	45 <org.chromium.ui.widget.ButtonCompat

	46 android:id="@+id/save_button"

	47 android:layout_width="wrap_content"

	48 android:layout_height="wrap_content"

	49 android:textColor="@android:color/white"

	50 android:text="@string/save"

	51 android:textAllCaps="true"

	52 android:textSize="16sp"

	53 android:layout_marginEnd="8dp"

	54 chrome:buttonColor="@color/light_active_color"

	55 chrome:buttonRaised="false"

	56 android:layout_gravity="center_vertical"/>
	Ian Wen 2016/09/23 20:43:25 And here And here ltian 2016/09/23 21:32:05 Done. Show quoted text On 2016/09/23 20:43:25, Ian Wen wrote: > And here Done.
	57 </LinearLayout>

	58

	59 </LinearLayout>

OLD	NEW