chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js - Issue 2362673004: Aligns text to braille in chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

Issue 2362673004: Aligns text to braille in chromevox. (Closed)

Patch Set: Addressed code reviews. Extracted grouping algorithm into a helper method. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

index 5f2039a212dfe04518e72764919125341fd32e40..ba81490b477a353603b5033a13c0ebce1adda9f8 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

@@ -199,7 +199,8 @@ cvox.BrailleDisplayManager.prototype.refresh_ = function() {

var start = this.brailleToTextPosition_(viewPort.start);

var end = this.brailleToTextPosition_(viewPort.end);

cvox.BrailleCaptionsBackground.setContent(

- this.content_.text.toString().substring(start, end), buf);

+ this.content_.text.toString().substring(start, end), buf,

+ this.brailleToText_);

}

};