Aligns text to braille in chromevox.

chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager_test.unitjs

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['../testing/chromevox_unittest_base.js',
              '../testing/fake_objects.js']);
 
 /**
  * Test fixture.
@@ skipping 73 matching lines @@
    * Asserts that the last written display content is an empty buffer of
    * of cells and clears the list of written cells.
    * There must be only one buffer in the list.
    */
   assertEmptyDisplayAndClear: function() {
     assertEquals(1, this.writtenCells.length);
     var content = this.writtenCells[0];
     this.writtenCells.length = 0;
     assertTrue(content instanceof ArrayBuffer);
     assertTrue(content.byteLength == 0);
+  },
+
+  /**
+   * Asserts that the last written display content is an empty buffer of

[dmazzoni, 2016/10/04 22:34:30]

Update this comment

[ultimatedbz, 2016/10/08 01:00:44]

Done.

+   * of cells and clears the list of written cells.
+   * There must be only one buffer in the list.
+   */
+  assertGroupValid: function(groups, expected) {

[dmazzoni, 2016/10/04 22:34:30]

Maybe assertGroupsValid?

[ultimatedbz, 2016/10/08 01:00:44]

Done.

+    assertEquals(JSON.stringify(groups), JSON.stringify(expected));
   }
 };
 
 /** @extends {cvox.ExpandingBrailleTranslator} */
 function FakeTranslator() {
 }
 
 FakeTranslator.prototype = {
   /**
    * Does a translation where every other character becomes two cells.
@@ skipping 92 matching lines @@
   this.assertEmptyDisplayAndClear();
   manager.setContent(this.NAV_BRAILLE);
   this.assertEmptyDisplayAndClear();
   this.translatorManager.setTranslator(this.translator);
   this.assertDisplayPositionAndClear(0);
   manager.setContent(this.NAV_BRAILLE);
   this.assertDisplayPositionAndClear(0);
 });
 
 
+

[dmazzoni, 2016/10/04 22:34:30]

Nit: get rid of extra blank line

 /**
  * Tests that setting empty content clears the display.
  */
 TEST_F('CvoxBrailleDisplayManagerUnitTest', 'SetEmptyContentWithTranslator',
        function() {
   this.addFakeApi();
   this.displayAvailable();
 
   var manager = new cvox.BrailleDisplayManager(this.translatorManager);
   this.assertEmptyDisplayAndClear();
@@ skipping 32 matching lines @@
       2 * this.DISPLAY_SIZE,
       translatedSize % this.DISPLAY_SIZE);
   // Selection from the end of what fits on the first display to the end of the
   // line.
   manager.setContent(createNavBrailleWithCursor(7, text.length));
   this.assertDisplayPositionAndClear(0, 10, this.DISPLAY_SIZE);
   // Selection on all of the line.
   manager.setContent(createNavBrailleWithCursor(0, text.length));
   this.assertDisplayPositionAndClear(0, 0, this.DISPLAY_SIZE);
 });
+
+/**
+ * Tests that the grouping algorithm works with one regular letter that maps
+ * to one braille letter.

[dmazzoni, 2016/10/04 22:34:30]

Use "braille cell" instead of "braille letter", and "text character" instead of
"regular letter" (and in several other places)

[ultimatedbz, 2016/10/08 01:00:44]

Done.

+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'BasicGroup', function() {
+  var text = 'a';
+  var translated = '1';
+  var mapping = [0];
+  var expected = [['a','1']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);

[dmazzoni, 2016/10/04 22:34:30]

Wrap to 80 chars, here and in one or two other places

+  this.assertGroupValid(groups, expected);
+});
+
+/**
+ * Tests that the grouping algorithm works with one regular letter that maps
+ * to multiple braille letters.
+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'OneRtoManyB', function() {
+  var text = 'A';
+  var translated = '11';
+  var mapping = [0,0];
+  var expected = [['A', '11']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);
+  this.assertGroupValid(groups, expected);
+});
+
+/**
+ * Tests that the grouping algorithm works with one braille letter that maps
+ * to multiple regular letters.
+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'OneBtoManyR', function() {
+  var text = 'knowledge';
+  var translated = '1';
+  var mapping = [0];
+  var expected = [['knowledge', '1']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);
+  this.assertGroupValid(groups, expected);
+});
+
+/**
+ * Tests that the grouping algorithm works with one string that on both ends,
+ * have regular letters that map to multiple braille letters.
+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'OneRtoManyB_BothEnds', function() {
+  var text = 'AbbC';
+  var translated = 'X122X3';
+  var mapping = [0,0,1,2,3,3];
+  var expected = [['A', 'X1'], ['b', '2'],['b', '2'], ['C', 'X3']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);
+  this.assertGroupValid(groups, expected);
+});
+
+/**
+ * Tests that the grouping algorithm works with one string that on both ends,
+ * have braille letters that map to multiple regular letters.
+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'OneBtoManyR_BothEnds', function() {
+  var text = 'knowledgehappych';
+  var translated = '1234456';
+  var mapping = [0, 9, 10, 11, 12, 13, 14];
+  var expected = [['knowledge', '1'], ['h', '2'], ['a', '3'], ['p', '4'],
+      ['p', '4'], ['y', '5'], ['ch', '6']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);
+  this.assertGroupValid(groups, expected);
+});
+
+/**
+ * Tests that the grouping algorithm works with one  string that has both types
+ * of mapping.
+ */
+TEST_F('CvoxBrailleDisplayManagerUnitTest', 'RandB_Random', function() {
+  var text = 'knowledgeIsPower';
+  var translated = '1X23X45678';
+  var mapping = [0, 9, 9, 10, 11, 11, 12, 13, 14, 15];
+  var expected = [['knowledge', '1'], ['I', 'X2'], ['s', '3'], ['P', 'X4'], ['o', '5'],
+      ['w', '6'], ['e', '7'], ['r', '8']];
+
+  var groups = cvox.BrailleCaptionsBackground.groupBrailleAndText(translated, text, mapping);
+  this.assertGroupValid(groups, expected);
+});