[wasm] Break loops in the module-decoder upon error.

[wasm] Break loops in the module-decoder upon error.

R=titzer@chromium.org

Committed: https://crrev.com/396dbab65e2f54c4f8402f6bc1059f1e6b3aa66e
Cr-Commit-Position: refs/heads/master@{#39628}

[ahaas, 2016-09-22 09:51:13]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 09:51:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-09-22 09:53:11]

lgtm, but this CL will be superceded by 0xC

https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:190: if (failed()) break;
Can we change all these loops to be for(x, ok() && y; x++)?

This is the format I've used in 0xC

[commit-bot: I haz the power, 2016-09-22 10:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 10:38:16]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-22 12:35:03]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 12:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-22 12:35:10]

https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:190: if (failed()) break;
On 2016/09/22 at 09:53:11, titzer wrote:
> Can we change all these loops to be for(x, ok() && y; x++)?
> 
> This is the format I've used in 0xC

Done.

[ahaas, 2016-09-22 12:43:52]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 12:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 13:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 13:09:01]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-22 13:51:58]

On 2016/09/22 at 12:35:10, ahaas wrote:
> https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc
> File src/wasm/module-decoder.cc (right):
> 
>
https://codereview.chromium.org/2362663002/diff/1/src/wasm/module-decoder.cc#...
> src/wasm/module-decoder.cc:190: if (failed()) break;
> On 2016/09/22 at 09:53:11, titzer wrote:
> > Can we change all these loops to be for(x, ok() && y; x++)?
> > 
> > This is the format I've used in 0xC
> 
> Done.

I changed all loops now.

[ahaas, 2016-09-22 13:52:02]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-22 13:52:02]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2362663002/#ps40001
(title: "Change all loop breaks to the same pattern.")

[commit-bot: I haz the power, 2016-09-22 13:52:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 13:54:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 13:54:48]

Description was changed from

==========
[wasm] Break loops in the module-decoder upon error.

R=titzer@chromium.org
==========

to

==========
[wasm] Break loops in the module-decoder upon error.

R=titzer@chromium.org

Committed: https://crrev.com/396dbab65e2f54c4f8402f6bc1059f1e6b3aa66e
Cr-Commit-Position: refs/heads/master@{#39628}
==========

[commit-bot: I haz the power, 2016-09-22 13:54:48]

Patchset 3 (id:??) landed as
https://crrev.com/396dbab65e2f54c4f8402f6bc1059f1e6b3aa66e
Cr-Commit-Position: refs/heads/master@{#39628}