Convert LayoutTests/svg/dom/SVGTransform*.html js-tests.js to testharness.js based tests

Convert LayoutTests/svg/dom/SVGTransform*.html js-tests.js to testharness.js based tests

BUG=636710
Committed: https://crrev.com/c7e97c1604e0d4c9e42f357365ba609fb3ef92fd
Cr-Commit-Position: refs/heads/master@{#420830}

[Shanmuga Pandi, 2016-09-22 09:20:22]

shanmuga.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Shanmuga Pandi, 2016-09-22 09:20:24]

PTAL!!

[Srirama, 2016-09-22 10:16:26]

lgtm

[Shanmuga Pandi, 2016-09-22 10:17:58]

shanmuga.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Shanmuga Pandi, 2016-09-22 10:17:58]

PTAL!!

[fs, 2016-09-22 11:43:20]

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html (right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html:34:
assert_equals(transform.matrix.e = 100, 100);
Just do this as:

transform.matrix.e = 100;

and then rely on the verification below.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html:46:
assert_equals(transform.matrix.e = 0, 0);
Ditto for these two.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html
(right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:10:
test(function() {
I think it'd be better to have several (sub)test here rather than one (fairly
large) test. Splitting on the method being tested seems reasonable. No need to
do that here though.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:107:
assert_equals(transformList.replaceItem(transformList.getItem(0), 0).toString(),
"type=SVG_TRANSFORM_ROTATE matrix=[0.0 1.0 -1.0 0.0 0.0 0.0]");
Here we are replacing the element with itself - from a testing PoV this means we
can't really be sure the replacement actually to place (preferably we'd just
check the object identities, but that's broken IIRC.) Maybe another object/index
can be used.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:171:
assert_equals((transform = svg.createSVGTransform()).toString(),
"type=SVG_TRANSFORM_MATRIX matrix=[1.0 0.0 0.0 1.0 0.0 0.0]");
Assign the transform outside the assert.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-with-existing-item.html
(right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-with-existing-item.html:14:
// This is a test of more SVGTransformList API parts.
This could be less vague: "This is of mutations of a SVGTransformList with an
SVGTransform that already exist in a list."

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransformList.html (right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList.html:2:
<title>SVGTransformList interface</title>
Maybe we can give this test a more specific name. It appears to be testing the
(IDL) contract (argument type-check) of createSVGTransformFromMatrix, so maybe
add that to title and filename.

[Shanmuga Pandi, 2016-09-23 11:29:44]

Patchset #2 (id:20001) has been deleted

[Shanmuga Pandi, 2016-09-23 11:37:03]

PTAL

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html (right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html:34:
assert_equals(transform.matrix.e = 100, 100);
On 2016/09/22 11:43:20, fs wrote:
> Just do this as:
> 
> transform.matrix.e = 100;
> 
> and then rely on the verification below.

Done.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransform.html:46:
assert_equals(transform.matrix.e = 0, 0);
On 2016/09/22 11:43:20, fs wrote:
> Ditto for these two.

Done.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html
(right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:10:
test(function() {
On 2016/09/22 11:43:20, fs wrote:
> I think it'd be better to have several (sub)test here rather than one (fairly
> large) test. Splitting on the method being tested seems reasonable. No need to
> do that here though.

Added TODO.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:107:
assert_equals(transformList.replaceItem(transformList.getItem(0), 0).toString(),
"type=SVG_TRANSFORM_ROTATE matrix=[0.0 1.0 -1.0 0.0 0.0 0.0]");
On 2016/09/22 11:43:20, fs wrote:
> Here we are replacing the element with itself - from a testing PoV this means
we
> can't really be sure the replacement actually to place (preferably we'd just
> check the object identities, but that's broken IIRC.) Maybe another
object/index
> can be used.

Done.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-basics.html:171:
assert_equals((transform = svg.createSVGTransform()).toString(),
"type=SVG_TRANSFORM_MATRIX matrix=[1.0 0.0 0.0 1.0 0.0 0.0]");
On 2016/09/22 11:43:20, fs wrote:
> Assign the transform outside the assert.

Done.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-with-existing-item.html
(right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList-with-existing-item.html:14:
// This is a test of more SVGTransformList API parts.
On 2016/09/22 11:43:20, fs wrote:
> This could be less vague: "This is of mutations of a SVGTransformList with an
> SVGTransform that already exist in a list."

Done.

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGTransformList.html (right):

https://codereview.chromium.org/2362653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGTransformList.html:2:
<title>SVGTransformList interface</title>
On 2016/09/22 11:43:20, fs wrote:
> Maybe we can give this test a more specific name. It appears to be testing the
> (IDL) contract (argument type-check) of createSVGTransformFromMatrix, so maybe
> add that to title and filename.

Done.

[fs, 2016-09-23 11:44:52]

lgtm

[Shanmuga Pandi, 2016-09-23 11:47:13]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-09-23 11:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
srirama.m@samsung.com
Link to the patchset: https://codereview.chromium.org/2362653002/#ps40001
(title: "Align with review comments")

[commit-bot: I haz the power, 2016-09-23 11:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 12:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 12:25:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shanmuga Pandi, 2016-09-24 05:13:52]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-09-24 05:14:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 06:05:19]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-24 06:06:58]

Description was changed from

==========
Convert LayoutTests/svg/dom/SVGTransform*.html js-tests.js to testharness.js
based tests

BUG=636710
==========

to

==========
Convert LayoutTests/svg/dom/SVGTransform*.html js-tests.js to testharness.js
based tests

BUG=636710

Committed: https://crrev.com/c7e97c1604e0d4c9e42f357365ba609fb3ef92fd
Cr-Commit-Position: refs/heads/master@{#420830}
==========

[commit-bot: I haz the power, 2016-09-24 06:06:59]

Patchset 2 (id:??) landed as
https://crrev.com/c7e97c1604e0d4c9e42f357365ba609fb3ef92fd
Cr-Commit-Position: refs/heads/master@{#420830}