Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2362563004: re-land fix #27110 with proper DDC side of changes (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix pre/postifx ops #

Total comments: 2

Patch Set 3 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -151 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/ast_properties.dart View 1 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 10 chunks +105 lines, -92 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 2 7 chunks +39 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/non_null_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 11 chunks +23 lines, -22 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/reify_coercions.dart View 1 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jennifer Messerly
Fix is updated & verified that it works with DDC this time :)
4 years, 3 months ago (2016-09-22 22:01:48 UTC) #2
Jennifer Messerly
Original review was here: https://codereview.chromium.org/2271223004/ bug is here: https://github.com/dart-lang/sdk/issues/27110
4 years, 3 months ago (2016-09-22 22:02:38 UTC) #3
Leaf
lgtm https://codereview.chromium.org/2362563004/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/2362563004/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode3894 pkg/analyzer/test/src/task/strong/checker_test.dart:3894: /*info:DOWN_CAST_IMPLICIT_ASSIGN*/b--; Maybe test the case where we are ...
4 years, 3 months ago (2016-09-22 22:30:17 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/2362563004/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/2362563004/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode3894 pkg/analyzer/test/src/task/strong/checker_test.dart:3894: /*info:DOWN_CAST_IMPLICIT_ASSIGN*/b--; On 2016/09/22 22:30:17, Leaf wrote: > Maybe test ...
4 years, 3 months ago (2016-09-22 22:32:19 UTC) #5
Jennifer Messerly
4 years, 3 months ago (2016-09-22 22:48:05 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
adc71ab396ed16b0a7b565fc7d2232170af2dcf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698