Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2362563002:
Add regression test for crbug.com/648740. (Closed)
DescriptionAdd regression test for crbug.com/648740.
BUG=648740
Committed: https://crrev.com/68ee0a4f901c3c199e3724c4f5aed16ac1c17977
Cr-Commit-Position: refs/heads/master@{#39643}
Patch Set 1 #Patch Set 2 : Add regression test for crbug.com/648740. #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lpy@chromium.org changed reviewers: + adamk@chromium.org
PTAL.
verwaest@chromium.org changed reviewers: + verwaest@chromium.org
I have a cl that drops this entirely as it's unnecessary.
Nice! I tried to drop this before but I failed for some reasons :( Thanks, I will close this patch :)
Message was sent while issue was closed.
Can you still land this patch for its test?
Message was sent while issue was closed.
On 2016/09/22 18:19:14, adamk wrote: > Can you still land this patch for its test? (lgtm on the test to make that easy)
Message was sent while issue was closed.
Description was changed from ========== Fix crash on AnalyzePartially. When we decide to discard function body after parsing, we shouldn't declare arguments in main zone scope. BUG=648740 ========== to ========== Fix crash on AnalyzePartially. When we decide to discard function body after parsing, we shouldn't declare arguments in main zone scope. BUG=648740 ==========
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix crash on AnalyzePartially. When we decide to discard function body after parsing, we shouldn't declare arguments in main zone scope. BUG=648740 ========== to ========== Add regression test for crbug.com/648740. BUG=648740 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9457) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lpy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2362563002/#ps20001 (title: "Add regression test for crbug.com/648740.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add regression test for crbug.com/648740. BUG=648740 ========== to ========== Add regression test for crbug.com/648740. BUG=648740 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add regression test for crbug.com/648740. BUG=648740 ========== to ========== Add regression test for crbug.com/648740. BUG=648740 Committed: https://crrev.com/68ee0a4f901c3c199e3724c4f5aed16ac1c17977 Cr-Commit-Position: refs/heads/master@{#39643} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/68ee0a4f901c3c199e3724c4f5aed16ac1c17977 Cr-Commit-Position: refs/heads/master@{#39643} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
