Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5115)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2362523003: Add (some) password detection for HTTP-bad (Closed)
Patch Set: trigger the downgrade from OnPasswordFormsParsed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/password/simple_password_in_iframe.html ('k') | content/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 722416e5ef18a4ce108d6b97ec45a126b8a94a61..9f2bc1fbc72d6e11fd3b035ac5c180796ba3b2dd 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -22,11 +22,24 @@
#include "content/public/browser/site_instance.h"
#include "content/public/browser/ssl_status.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/origin_util.h"
#include "net/cert/cert_status_flags.h"
#include "services/shell/public/cpp/interface_provider.h"
namespace password_manager {
+namespace {
+
+void MaybeNotifyPasswordInputShownOnHttp(content::RenderFrameHost* rfh) {
+ content::WebContents* web_contents =
+ content::WebContents::FromRenderFrameHost(rfh);
+ if (!content::IsOriginSecure(web_contents->GetVisibleURL())) {
+ web_contents->OnPasswordInputShownOnHttp();
+ }
+}
+
+} // namespace
+
ContentPasswordManagerDriver::ContentPasswordManagerDriver(
content::RenderFrameHost* render_frame_host,
PasswordManagerClient* client,
@@ -156,6 +169,7 @@ void ContentPasswordManagerDriver::PasswordFormsParsed(
void ContentPasswordManagerDriver::OnPasswordFormsParsedNoRenderCheck(
const std::vector<autofill::PasswordForm>& forms) {
+ MaybeNotifyPasswordInputShownOnHttp(render_frame_host_);
GetPasswordManager()->OnPasswordFormsParsed(this, forms);
GetPasswordGenerationManager()->CheckIfFormClassifierShouldRun();
}
« no previous file with comments | « chrome/test/data/password/simple_password_in_iframe.html ('k') | content/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698