chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 2362523003: Add (some) password detection for HTTP-bad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2362523003: Add (some) password detection for HTTP-bad (Closed)

Patch Set: trigger the downgrade from OnPasswordFormsParsed Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 8b585e4f708125ca7f8107b0c726122b64bb9474..556dfc799e8c77cd3b47fdd877ce0a18d3bd4cc0 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -604,7 +604,9 @@ void OmniboxViewMac::ApplyTextAttributes(

// Emphasize the scheme for security UI display purposes (if necessary).

if (!model()->user_input_in_progress() && model()->CurrentTextIsURL() &&

scheme.is_nonempty() &&

- (security_level != security_state::SecurityStateModel::NONE)) {

+ (security_level != security_state::SecurityStateModel::NONE) &&

+ (security_level !=

+ security_state::SecurityStateModel::HTTP_SHOW_WARNING)) {

if (security_level == security_state::SecurityStateModel::DANGEROUS) {

// Add a strikethrough through the scheme.

[attributedString addAttribute:NSStrikethroughStyleAttributeName