Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2362503003: [promises] PromiseResolveThenableJob: change then to be a JSReceiver (Closed)

Created:
4 years, 3 months ago by gsathya
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] PromiseResolveThenableJob: change then to be a JSReceiver BUG=v8:649078 Committed: https://crrev.com/ba41697cbd72ea7dcdd89e6dbe9090ecb156ce6c Cr-Commit-Position: refs/heads/master@{#39609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-649078.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
gsathya
PTAL
4 years, 3 months ago (2016-09-21 22:46:10 UTC) #7
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-09-21 22:47:02 UTC) #8
adamk
lgtm
4 years, 3 months ago (2016-09-21 22:48:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362503003/1
4 years, 3 months ago (2016-09-21 22:48:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 23:55:42 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 23:56:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba41697cbd72ea7dcdd89e6dbe9090ecb156ce6c
Cr-Commit-Position: refs/heads/master@{#39609}

Powered by Google App Engine
This is Rietveld 408576698