Replace kIgnoreSoloWindowFramePointerPolicy with global flag

Replace kIgnoreSoloWindowFramePointerPolicy with global flag

Looks like this doesn't have to be a window property.
Changed to use a plain global flag.

BUG=272460
R=jamescook@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221526

[James Cook, 2013-09-04 18:25:21]

LGTM with typo nit.  I like this change a lot.

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.cc
File ash/wm/frame_painter.cc (right):

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.cc#newco...
ash/wm/frame_painter.cc:759: if (!solo_window_header_enabled)
Good catch that this can be done before IsSoloWindowHeaderCandidate, which is an
expensive function.

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.h
File ash/wm/frame_painter.h (right):

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.h#newcode75
ash/wm/frame_painter.h:75: // Enable/Disable the solo-wnidow transparent header
appearance.
wnidow -> window

optional: Maybe "appearance feature"?  Or something to help reinforce that it's
not just setting it for one window, but turning the feature off for all
windows/root windows?

optional: Maybe call the function SetSoloWindowHeader*s*Enabled() ?

[oshima, 2013-09-04 18:30:55]

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.h
File ash/wm/frame_painter.h (right):

https://codereview.chromium.org/23625007/diff/1/ash/wm/frame_painter.h#newcode75
ash/wm/frame_painter.h:75: // Enable/Disable the solo-wnidow transparent header
appearance.
On 2013/09/04 18:25:21, James Cook wrote:
> wnidow -> window
done

> optional: Maybe "appearance feature"?  Or something to help reinforce that
it's
> not just setting it for one window, but turning the feature off for all
> windows/root windows?

changed to "appearance feature"
 
> optional: Maybe call the function SetSoloWindowHeader*s*Enabled() ?

done

[commit-bot: I haz the power, 2013-09-05 17:40:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/23625007/9001

[commit-bot: I haz the power, 2013-09-05 17:48:43]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-09-05 18:03:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/23625007/9001

[oshima, 2013-09-05 21:54:41]

Committed patchset #2 manually as r221526 (presubmit successful).