src/spaces.cc - Issue 23625003: Cleanup Mutex and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/spaces.cc

Issue 23625003: Cleanup Mutex and related classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/spaces.cc

diff --git a/src/spaces.cc b/src/spaces.cc

index 8a5aa03a4bb397c534992aa1f737f091f99ecb24..e62d381a18399242cefb7c8877c0e57a322b74c8 100644

--- a/src/spaces.cc

+++ b/src/spaces.cc

@@ -2043,8 +2043,8 @@ intptr_t FreeListCategory::Concatenate(FreeListCategory* category) {

// This is safe (not going to deadlock) since Concatenate operations

// are never performed on the same free lists at the same time in

// reverse order.

- ScopedLock lock_target(mutex_);

- ScopedLock lock_source(category->mutex());

+ LockGuard<Mutex> target_lock_guard(mutex());

+ LockGuard<Mutex> source_lock_guard(category->mutex());

free_bytes = category->available();

if (end_ == NULL) {

end_ = category->end();