Stack sampling profiler: set process and thread information

Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958
Committed: https://crrev.com/4472aa947dabb7edd857fee3a2182b8181167a9f
Cr-Commit-Position: refs/heads/master@{#420439}

[Mike Wittman, 2016-09-21 20:30:11]

Description was changed from

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread data profiling scenarios in the resulting data.

BUG=517958
==========

to

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread data profiling scenarios in the resulting data.

BUG=517958
==========

[Mike Wittman, 2016-09-21 20:30:11]

wittman@chromium.org changed reviewers:
+ isherman@chromium.org, sky@chromium.org, tsepez@chromium.org

[Mike Wittman, 2016-09-21 20:30:34]

Description was changed from

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread data profiling scenarios in the resulting data.

BUG=517958
==========

to

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958
==========

[Mike Wittman, 2016-09-21 20:31:27]

PTAL

isherman: components/metrics, chrome/browser/metrics
tsepez: struct_traits, mojom
sky: chrome/browser/chrome_browser_main.cc,
chrome/browser/chrome_browser_main.cc

[Mike Wittman, 2016-09-21 20:38:02]

The CQ bit was checked by wittman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:38:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-21 20:45:03]

mojom / traits LGTM.

[commit-bot: I haz the power, 2016-09-21 21:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:17:33]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mike Wittman, 2016-09-21 21:22:47]

The CQ bit was checked by wittman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:23:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike Wittman, 2016-09-21 22:04:55]

Er, this should be:

sky: chrome/browser/chrome_browser_main.cc,
*chrome/gpu/chrome_content_gpu_client.cc*

[sky, 2016-09-21 22:06:16]

Said files LGTM. I had started looking at some of other files before realizing
you only wanted me to look at a couple. So, here's some bonus comments:)

https://codereview.chromium.org/2362493002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/thread_watcher.h (right):

https://codereview.chromium.org/2362493002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/thread_watcher.h:666:
metrics::CallStackProfileParams::Thread thread_;
const

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
File components/metrics/call_stack_profile_collector.h (right):

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_collector.h:17:
CallStackProfileCollector(CallStackProfileParams::Process expected_process);
explicit

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_collector.h:33:
CallStackProfileParams::Process expected_process_;
const

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
File components/metrics/call_stack_profile_metrics_provider.cc (right):

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_metrics_provider.cc:298: break;
No break after returns in these switches.

[commit-bot: I haz the power, 2016-09-21 22:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:11:14]

Dry run: This issue passed the CQ dry run.

[Mike Wittman, 2016-09-21 22:26:21]

https://codereview.chromium.org/2362493002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/thread_watcher.h (right):

https://codereview.chromium.org/2362493002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/thread_watcher.h:666:
metrics::CallStackProfileParams::Thread thread_;
On 2016/09/21 22:06:16, sky wrote:
> const

Done.

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
File components/metrics/call_stack_profile_collector.h (right):

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_collector.h:17:
CallStackProfileCollector(CallStackProfileParams::Process expected_process);
On 2016/09/21 22:06:16, sky wrote:
> explicit

Done.

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_collector.h:33:
CallStackProfileParams::Process expected_process_;
On 2016/09/21 22:06:16, sky wrote:
> const

Done.

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
File components/metrics/call_stack_profile_metrics_provider.cc (right):

https://codereview.chromium.org/2362493002/diff/20001/components/metrics/call...
components/metrics/call_stack_profile_metrics_provider.cc:298: break;
On 2016/09/21 22:06:16, sky wrote:
> No break after returns in these switches.

Done.

[Ilya Sherman, 2016-09-22 01:01:19]

lgtm

[Mike Wittman, 2016-09-22 16:33:04]

The CQ bit was checked by wittman@chromium.org

[Mike Wittman, 2016-09-22 16:33:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2362493002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-22 16:33:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:08:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike Wittman, 2016-09-22 17:09:58]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:59:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike Wittman, 2016-09-22 19:19:02]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2016-09-22 19:19:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:14:08]

Description was changed from

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958
==========

to

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958
==========

[commit-bot: I haz the power, 2016-09-22 20:14:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 20:18:16]

Description was changed from

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958
==========

to

==========
Stack sampling profiler: set process and thread information

Adds process and thread state to CallStackProfileParams, and sets it at
the the profiler call sites. Propagates this information to the
associated UMA protobuf. This state is required to distinguish different
process/thread profiling scenarios in the resulting data.

BUG=517958

Committed: https://crrev.com/4472aa947dabb7edd857fee3a2182b8181167a9f
Cr-Commit-Position: refs/heads/master@{#420439}
==========

[commit-bot: I haz the power, 2016-09-22 20:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/4472aa947dabb7edd857fee3a2182b8181167a9f
Cr-Commit-Position: refs/heads/master@{#420439}