Adding unit test for DrawingBuffer's bitmap recycling mechanism

Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org

Committed: https://crrev.com/31773420c8a5519f97332ba7c76568c8fa5d6ff8
Cr-Commit-Position: refs/heads/master@{#420509}

[Justin Novosad, 2016-09-21 19:58:25]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-09-21 20:02:47]

junov@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, xidachen@chromium.org

[Justin Novosad, 2016-09-21 20:02:47]

PTAL.

Contents of DrawingBufferTestHelpers.h were just cut/pasted from
DrawingBufferTest.cpp so don't wast time doing a detailed review there.

[Justin Novosad, 2016-09-21 20:18:53]

junov@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-22 00:57:59]

Great job on the unit tests. LGTM once everything compiles and the new tests are
passing.

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
(right):

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp:120:
IntSize initialSize(InitialWidth, InitialHeight);
Unused?

[xidachen, 2016-09-22 01:48:16]

LGTM with nits.

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
(right):

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp:62:
std::unique_ptr<cc::SingleReleaseCallback> releaseCallback2;
callback2 doesn't seem to be used in this test.

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
(right):

https://codereview.chromium.org/2362473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp:82:
m_drawingBuffer->reset(IntSize(InitialWidth, AlternateHeight));
This is not introduced by your CL, but to be consistent, I think we should
either use:
1). The local vars initialSize && alternateSize
Or
2). remove the local vars and keep using IntSize(...) everywhere.

Personally I'd prefer 1).

I noticed that there are many places that are doing the same thing, could you
please do a pass and clean them all?

[Justin Novosad, 2016-09-22 21:52:41]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:53:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-09-22 21:58:59]

Description was changed from

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
==========

to

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org
==========

[Justin Novosad, 2016-09-22 21:59:03]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2016-09-22 22:08:27]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-09-22 22:08:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
xidachen@chromium.org, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2362473002/#ps60001
(title: "fix nits")

[commit-bot: I haz the power, 2016-09-22 22:09:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 00:01:05]

Description was changed from

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org
==========

to

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org
==========

[commit-bot: I haz the power, 2016-09-23 00:01:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-23 00:03:05]

Description was changed from

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org
==========

to

==========
Adding unit test for DrawingBuffer's bitmap recycling mechanism

This is a follow-up to https://codereview.chromium.org/2356803002
to add testing.

BUG=647896
TBR=phajdan.jr@chromium.org

Committed: https://crrev.com/31773420c8a5519f97332ba7c76568c8fa5d6ff8
Cr-Commit-Position: refs/heads/master@{#420509}
==========

[commit-bot: I haz the power, 2016-09-23 00:03:06]

Patchset 4 (id:??) landed as
https://crrev.com/31773420c8a5519f97332ba7c76568c8fa5d6ff8
Cr-Commit-Position: refs/heads/master@{#420509}