Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2362453003: Fix Endian issue in interpreter in EmitBytecode (Closed)

Created:
4 years, 3 months ago by john.yan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Endian issue in interpreter in EmitBytecode R=rmcilroy@chromium.org, mythria@chromium.org, leszeks@chromium.org BUG= Committed: https://crrev.com/3b1691be5e6684c423c5372bd0ced48dcc3d157b Cr-Commit-Position: refs/heads/master@{#39644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/interpreter/bytecode-array-writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 3 months ago (2016-09-22 17:49:43 UTC) #1
rmcilroy
lgtm
4 years, 3 months ago (2016-09-22 19:51:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362453003/1
4 years, 3 months ago (2016-09-22 20:16:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:45:03 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:45:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b1691be5e6684c423c5372bd0ced48dcc3d157b
Cr-Commit-Position: refs/heads/master@{#39644}

Powered by Google App Engine
This is Rietveld 408576698