Issue 23624005: Merge 218255 "Fix creating a directory in the Save-as dialog."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23624005: Merge 218255 "Fix creating a directory in the Save-as dialog." (Closed)

Created:
7 years, 3 months ago by hirono

Modified:
7 years, 3 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 218255 "Fix creating a directory in the Save-as dialog." > Fix creating a directory in the Save-as dialog. > > This regression was caused since we were listening for commands on the dialog container only. In the save-as dialog, the new folder button is on the footer, which is not a child of the dialog container. This patch adds listening for the command on the footer. > > TEST=Tested manually. > BUG=272765 > > Review URL: https://chromiumcodereview.appspot.com/22880017 TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219915

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r219915.

Expand Messages | Collapse Messages