Add UI for RuntimeErrors in the ErrorConsole

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js"></include>
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 287 matching lines @@
       // The extension warnings (describing runtime issues).
       if (extension.warnings) {
         var panel = node.querySelector('.extension-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.warnings.forEach(function(warning) {
           list.appendChild(document.createElement('li')).innerText = warning;
         });
       }
 
-      // The manifest errors and warnings, in one of two formats (depending on
-      // if the ErrorConsole is enabled).
+      // If the ErrorConsole is enabled, we should have manifest and/or runtime
+      // errors. Otherwise, we may have install warnings. We should not have
+      // both ErrorConsole errors and install warnings.
       if (extension.manifestErrors) {
-        var manifestErrors = node.querySelector('.manifest-errors');
-        manifestErrors.hidden = false;
-        manifestErrors.appendChild(
-            new extensions.ExtensionErrorList(extension.manifestErrors));
-      } else if (extension.installWarnings) {
+        var panel = node.querySelector('.manifest-errors');
+        panel.hidden = false;
+        panel.appendChild(new extensions.ExtensionErrorList(
+            extension.manifestErrors, 'extensionErrorsManifestErrors'));
+      }
+      if (extension.runtimeErrors) {
+        var panel = node.querySelector('.runtime-errors');
+        panel.hidden = false;
+        panel.appendChild(new extensions.ExtensionErrorList(
+            extension.runtimeErrors, 'extensionErrorsRuntimeErrors'));
+      }
+      if (extension.installWarnings) {
         var panel = node.querySelector('.install-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.installWarnings.forEach(function(warning) {
           var li = document.createElement('li');
           li.innerText = warning.message;
           list.appendChild(li);
         });
       }
 
       this.appendChild(node);
       if (location.hash.substr(1) == extension.id) {
         // Scroll beneath the fixed header so that the extension is not
         // obscured.
         var topScroll = node.offsetTop - $('page-header').offsetHeight;
         var pad = parseInt(getComputedStyle(node, null).marginTop, 10);
         if (!isNaN(pad))
           topScroll -= pad / 2;
         document.body.scrollTop = topScroll;
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });