Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2362383003: Fix build with system zlib (Closed)

Created:
4 years, 2 months ago by Paweł Hajdan Jr.
Modified:
4 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system zlib extensions/browser/api/cast_channel/logger.cc includes "third_party/zlib/zlib.h" and so the target should depend on zlib. BUG=none Committed: https://crrev.com/c446e0ea5f1db60f6396fc8c7d96e81c813d70da Cr-Commit-Position: refs/heads/master@{#421297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/browser/api/cast_channel/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Paweł Hajdan Jr.
4 years, 2 months ago (2016-09-23 23:48:06 UTC) #2
imcheng
lgtm
4 years, 2 months ago (2016-09-24 00:04:19 UTC) #5
Paweł Hajdan Jr.
+rockot,benwells for OWNERS
4 years, 2 months ago (2016-09-27 16:27:43 UTC) #9
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-09-27 16:28:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362383003/1
4 years, 2 months ago (2016-09-27 18:31:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:35:12 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:38:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c446e0ea5f1db60f6396fc8c7d96e81c813d70da
Cr-Commit-Position: refs/heads/master@{#421297}

Powered by Google App Engine
This is Rietveld 408576698