media/capture/video/linux/v4l2_capture_delegate.h - Issue 2362333002: Reland: Image Capture Linux/CrOs: wire some capabilities set/get

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/linux/v4l2_capture_delegate.h

Issue 2362333002: Reland: Image Capture Linux/CrOs: wire some capabilities set/get (Closed)

Patch Set: Added more condition Checks and cleaned up unit tests thread-hopping Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/linux/v4l2_capture_delegate.h

diff --git a/media/capture/video/linux/v4l2_capture_delegate.h b/media/capture/video/linux/v4l2_capture_delegate.h

index 66b63c60b244d8cf5e1a6cd9651723d2b1d61a01..12f9098a2adbbaadad6691a50c365b7f04b8c084 100644

--- a/media/capture/video/linux/v4l2_capture_delegate.h

+++ b/media/capture/video/linux/v4l2_capture_delegate.h

@@ -57,6 +57,11 @@ class V4L2CaptureDelegate final

void TakePhoto(VideoCaptureDevice::TakePhotoCallback callback);

+ void GetPhotoCapabilities(

+ VideoCaptureDevice::GetPhotoCapabilitiesCallback callback);

+ void SetPhotoOptions(mojom::PhotoSettingsPtr settings,

chfremer 2016/09/23 21:18:29 nit: photo options vs. photo settings, could be ma

mcasas 2016/09/23 22:10:57 They follow the idl names, which in turn come from

+ VideoCaptureDevice::SetPhotoOptionsCallback callback);

void SetRotation(int rotation);

private: