Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 236233002: Fix punctuation and remove a word from extension permission warnings. (Closed)

Created:
6 years, 8 months ago by meacer
Modified:
6 years, 8 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Fix punctuation and remove a word from extension permission warnings. BUG=362794 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264909

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/app/generated_resources.grd View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
meacer
dewittj: I changed the wording of systemIndicator permission from "Display and manage an icon in ...
6 years, 8 months ago (2014-04-12 00:04:12 UTC) #1
dewittj
sounds fine lgtm
6 years, 8 months ago (2014-04-16 17:51:27 UTC) #2
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-04-16 17:52:11 UTC) #3
meacer
On 2014/04/16 17:51:27, dewittj wrote: > sounds fine lgtm Thanks.
6 years, 8 months ago (2014-04-16 17:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/236233002/1
6 years, 8 months ago (2014-04-16 17:52:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 18:26:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61822
6 years, 8 months ago (2014-04-16 18:26:07 UTC) #7
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-04-16 21:33:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/236233002/20001
6 years, 8 months ago (2014-04-16 21:34:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 22:23:40 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61897
6 years, 8 months ago (2014-04-16 22:23:40 UTC) #11
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-04-19 01:14:03 UTC) #12
meacer
The CQ bit was unchecked by meacer@chromium.org
6 years, 8 months ago (2014-04-19 01:14:07 UTC) #13
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-04-19 01:15:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/236233002/60001
6 years, 8 months ago (2014-04-19 01:15:35 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 02:09:09 UTC) #16
Message was sent while issue was closed.
Change committed as 264909

Powered by Google App Engine
This is Rietveld 408576698