Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6685)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java

Issue 2362323002: [NTP Snippets] Reschedule background fetching on app upgrade if it was scheduled before (Closed)
Patch Set: bauerb review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsLauncher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
index 884e1eb135afaf30d97141bc122deb6302c92a62..ed6ca84ecc83b04f7a240240f17375735b55ea85 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
@@ -120,6 +120,11 @@ public class ChromeBackgroundService extends GcmTaskService {
SnippetsBridge.fetchSnippets(/*forceRequest=*/false);
}
+ @VisibleForTesting
+ protected void rescheduleFetching() {
+ SnippetsBridge.rescheduleFetching();
+ }
+
private void handlePrecache(Context context, String tag) {
if (!hasPrecacheInstance()) {
launchBrowser(context, tag);
@@ -202,9 +207,29 @@ public class ChromeBackgroundService extends GcmTaskService {
}
}
- @Override
- public void onInitializeTasks() {
+ @VisibleForTesting
+ protected void rescheduleBackgroundSyncTasksOnUpgrade() {
BackgroundSyncLauncher.rescheduleTasksOnUpgrade(this);
+ }
+
+ @VisibleForTesting
+ protected void reschedulePrecacheTasksOnUpgrade() {
PrecacheController.rescheduleTasksOnUpgrade(this);
}
+
+ private void rescheduleSnippetsTasksOnUpgrade() {
+ if (SnippetsLauncher.shouldRescheduleTasksOnUpgrade()) {
+ if (!SnippetsLauncher.hasInstance()) {
+ launchBrowser(this, /*tag=*/""); // The |tag| doesn't matter here.
+ }
+ rescheduleFetching();
+ }
+ }
+
+ @Override
+ public void onInitializeTasks() {
+ rescheduleBackgroundSyncTasksOnUpgrade();
+ reschedulePrecacheTasksOnUpgrade();
+ rescheduleSnippetsTasksOnUpgrade();
+ }
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsLauncher.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698