content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java - Issue 23623019: Support datalist for date/time input types on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

Issue 23623019: Support datalist for date/time input types on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/date_time_chooser_android.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/DateTimeSuggestion.java » ('j') | content/public/common/date_time_suggestion.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

index 07c1deb62afcf14263f70d674a795a8df63d340f..7efb69b67df0238261289becd3d74addc25dc6be 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

@@ -12,6 +12,7 @@ import android.os.Build;

import android.text.format.Time;

import android.view.LayoutInflater;

import android.view.View;

+import android.util.Log;

import android.widget.DatePicker;

import android.widget.DatePicker.OnDateChangedListener;

import android.widget.TimePicker;

@@ -60,11 +61,11 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,

int monthOfYear,

int dayOfMonth,

int hourOfDay, int minute, boolean is24HourView,

- long min, long max) {

+ double min, double max) {

super(context, 0);

- mMinTimeMillis = min;

- mMaxTimeMillis = max;

+ mMinTimeMillis = (long) min;

+ mMaxTimeMillis = (long) max;

mCallBack = callBack;

@@ -81,7 +82,7 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,

setView(view);

mDatePicker = (DatePicker) view.findViewById(R.id.date_picker);

DateDialogNormalizer.normalize(mDatePicker, this,

- year, monthOfYear, dayOfMonth, hourOfDay, minute, min, max);

+ year, monthOfYear, dayOfMonth, hourOfDay, minute, mMinTimeMillis, mMaxTimeMillis);

mTimePicker = (TimePicker) view.findViewById(R.id.time_picker);

mTimePicker.setIs24HourView(is24HourView);