Support datalist for date/time input types on Android

content/public/android/java/src/org/chromium/content/browser/input/DateTimeSuggestion.java

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.content.browser.input;
+
+/**
+ * Date/time suggestion container used to store information for each suggestion that will be shown
+ * in the suggestion list dialog.
+ */
+public class DateTimeSuggestion {
+    final String mValue;

[newt (away), 2013/10/09 07:20:52]

these should presumably have the same visibility as the class (e.g. public).
also, public fields shouldn't have "m" prefix.

[keishi, 2013/10/21 17:00:58]

Done.

+    final String mLocalizedValue;
+    final String mLabel;
+
+    /**
+     * Constructs a color suggestion container.
+     * @param value The suggested color.
+     * @param localizedValue The suggested color.
+     * @param label The label for the suggestion.
+     */
+    public DateTimeSuggestion(String value, String localizedValue, String label) {
+        mValue = value;
+        mLocalizedValue = localizedValue;
+        mLabel = label;
+    }
+}

[Miguel Garcia, 2013/10/08 17:44:40]

please implement equals() and hashcode() (and maybe toString()) since this is
meant to be used in data structures. Currently just an ArrayList but that could
change to say a hashMap at any point. In general it's good to have these methods
implemented.