Support datalist for date/time input types on Android

content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 import org.chromium.content.browser.ContentViewCore;
 
@@ skipping 21 matching lines @@
                     int second, int milli, int week) {
                 nativeReplaceDateTime(mNativeDateTimeChooserAndroid,
                         dialogType,
                         year, month, day, hour, minute, second, milli, week);
             }
 
             @Override
             public void cancelDateTimeDialog() {
                 nativeCancelDialog(mNativeDateTimeChooserAndroid);
             }
+
+            @Override
+            public void acceptDataListSuggestion(String value) {
+                nativeAcceptDataListSuggestion(mNativeDateTimeChooserAndroid, value);
+            }
         });
     }
 
     private void showDialog(int dialogType, int year, int month, int monthDay,
                             int hour, int minute, int second, int milli,
-                            int week, double min, double max, double step) {
+                            int week, double min, double max, double step,
+                            DateTimeSuggestion[] suggestions) {
         mInputDialogContainer.showDialog(
             dialogType, year, month, monthDay,
-            hour, minute, second, milli, week, min, max, step);
+            hour, minute, second, milli, week, min, max, step, suggestions);
     }
 
     @CalledByNative
     private static DateTimeChooserAndroid createDateTimeChooser(
             ContentViewCore contentViewCore,
             int nativeDateTimeChooserAndroid, int dialogType,
             int year, int month, int day,
             int hour, int minute, int second, int milli, int week,
-            double min, double max, double step) {
+            double min, double max, double step,
+            DateTimeSuggestion[] suggestions) {
         DateTimeChooserAndroid chooser =
                 new DateTimeChooserAndroid(
                         contentViewCore.getContext(),
                         nativeDateTimeChooserAndroid);
         chooser.showDialog(
             dialogType, year, month, day, hour, minute, second, milli,
-            week, min, max, step);
+            week, min, max, step, suggestions);
         return chooser;
     }
 
     @CalledByNative
+    private static DateTimeSuggestion[] createDateTimeSuggestionArray(int size) {

[Miguel Garcia, 2013/10/08 17:44:40]

why do you need to preallocate the array in java? You can simply created in C++
and pass it over.

[keishi, 2013/10/21 17:00:58]

Done.

+        return new DateTimeSuggestion[size];
+    }
+
+    /**
+     * @param array ColorSuggestion array that should get a new suggestion added.

[Miguel Garcia, 2013/10/08 17:44:40]

color suggestion? :)

No need to add suggestions one by one you can pass the array from C++ directly

[keishi, 2013/10/21 17:00:58]

Done.

+     * @param index Index in the array where to place a new suggestion.
+     * @param value Value of the suggestion.
+     * @param localizedValue Localized value of the suggestion.
+     * @param label Label of the suggestion.
+     */
+    @CalledByNative
+    private static void addToDateTimeSuggestionArray(DateTimeSuggestion[] array, int index,
+            String value, String localizedValue, String label) {
+        array[index] = new DateTimeSuggestion(value, localizedValue, label);
+    }
+
+    @CalledByNative
     private static void initializeDateInputTypes(
             int textInputTypeDate, int textInputTypeDateTime,
             int textInputTypeDateTimeLocal, int textInputTypeMonth,
             int textInputTypeTime, int textInputTypeWeek) {
         InputDialogContainer.initializeInputTypes(textInputTypeDate,
                 textInputTypeDateTime, textInputTypeDateTimeLocal,
                 textInputTypeMonth, textInputTypeTime, textInputTypeWeek);
     }
 
     private native void nativeReplaceDateTime(
             int nativeDateTimeChooserAndroid, int dialogType,
             int year, int month, int day, int hour, int minute,
             int second, int milli, int week);
 
     private native void nativeCancelDialog(int nativeDateTimeChooserAndroid);
+
+    private native void nativeAcceptDataListSuggestion(

[Miguel Garcia, 2013/10/08 17:44:40]

don't add an extra JNI method, I think you can just pass the right date/time
selected to C++

[keishi, 2013/10/21 17:00:58]

Done.

+            int nativeDateTimeChooserAndroid, String value);
 }