Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 23623009: Always visit branches during HGraph building (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Always visit branches during HGraph building even if constant values indicate that they are unreachable. BUG=chromium:280333 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M src/hydrogen.cc View 1 chunk +0 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-280333.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 3 months ago (2013-08-29 11:41:49 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-08-29 14:30:22 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-29 14:55:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16431 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698