Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2362263003: Disable WebSockets API in suborigins (Closed)

Created:
4 years, 3 months ago by jww
Modified:
4 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, haraken, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebSockets API in suborigins For v1 of the spec, the Suborigins spec disables WebSockets until it is decided how the presence of a suborigin should be communicated. This CL throws a JS SecurityException when the application tries to create a WebSockets object from a suborigin.Added LayoutTest for exception BUG=649239 Committed: https://crrev.com/8c8b27dda56ab54ec9028335ff0328aae0530feb Cr-Commit-Position: refs/heads/master@{#420987}

Patch Set 1 #

Patch Set 2 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-websocket.php View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jww
Mike, pending a spec update, (https://github.com/w3c/webappsec-suborigins/pull/46), suborigins will explicitly disable WebSockets for now. This CL ...
4 years, 3 months ago (2016-09-23 20:24:53 UTC) #2
Mike West
lgtm
4 years, 2 months ago (2016-09-26 07:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362263003/20001
4 years, 2 months ago (2016-09-26 16:17:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286234)
4 years, 2 months ago (2016-09-26 17:43:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362263003/20001
4 years, 2 months ago (2016-09-26 17:49:36 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 20:54:55 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 20:56:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c8b27dda56ab54ec9028335ff0328aae0530feb
Cr-Commit-Position: refs/heads/master@{#420987}

Powered by Google App Engine
This is Rietveld 408576698