Unbreak mac component build.

Unbreak mac component build.

Components named "system" shadow /usr/lib/libSystem.dylib on OS X.
Give the component a different output name, and also add an action for
a while that cleans up libsystem.dylib from existing build dirs.

BUG=649696
Committed: https://crrev.com/0dfb6ba0b31eae8c8d2aab54ece37bb9ae29e9ea
Cr-Commit-Position: refs/heads/master@{#420752}

[Nico, 2016-09-23 21:08:49]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:09:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-09-23 21:10:14]

thakis@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-09-23 21:12:11]

LGTM, thanks

[Nico, 2016-09-23 21:13:19]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-09-23 21:13:23]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:13:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-09-23 21:15:25]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2016-09-23 21:15:26]

Does rmdir_and_stamp.py not work (though I think the explicit args are better)?
https://cs.chromium.org/chromium/src/build/rmdir_and_stamp.py?sq=package:chro...

[Nico, 2016-09-23 21:18:33]

On 2016/09/23 21:15:26, Robert Sesek wrote:
> Does rmdir_and_stamp.py not work (though I think the explicit args are
better)?
>
https://cs.chromium.org/chromium/src/build/rmdir_and_stamp.py?sq=package:chro...

It probably does. I have a separate branch to remove that script since it looked
unused. I guess I could use it here instead of deleting it and adding a very
similar script...one sec.

[Nico, 2016-09-23 21:18:35]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-09-23 21:20:28]

On 2016/09/23 21:18:33, Nico wrote:
> On 2016/09/23 21:15:26, Robert Sesek wrote:
> > Does rmdir_and_stamp.py not work (though I think the explicit args are
> better)?
> >
>
https://cs.chromium.org/chromium/src/build/rmdir_and_stamp.py?sq=package:chro...
> 
> It probably does. I have a separate branch to remove that script since it
looked
> unused. I guess I could use it here instead of deleting it and adding a very
> similar script...one sec.

Nope, doesn't work:

FAILED: gen/mojo/public/cpp/system/clean_up_stamp 
python ../../build/rmdir_and_stamp.py libsystem.dylib
gen/mojo/public/cpp/system/clean_up_stamp
Traceback (most recent call last):
  File "../../build/rmdir_and_stamp.py", line 45, in <module>
    sys.exit(Main(sys.argv[1], sys.argv[2]))
  File "../../build/rmdir_and_stamp.py", line 40, in Main
    raise e
OSError: [Errno 20] Not a directory: 'libsystem.dylib'

[Nico, 2016-09-23 21:21:07]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-09-23 21:23:06]

On 2016/09/23 21:20:28, Nico wrote:
> On 2016/09/23 21:18:33, Nico wrote:
> > On 2016/09/23 21:15:26, Robert Sesek wrote:
> > > Does rmdir_and_stamp.py not work (though I think the explicit args are
> > better)?
> > >
> >
>
https://cs.chromium.org/chromium/src/build/rmdir_and_stamp.py?sq=package:chro...
> > 
> > It probably does. I have a separate branch to remove that script since it
> looked
> > unused. I guess I could use it here instead of deleting it and adding a very
> > similar script...one sec.
> 
> Nope, doesn't work:
> 
> FAILED: gen/mojo/public/cpp/system/clean_up_stamp 
> python ../../build/rmdir_and_stamp.py libsystem.dylib
> gen/mojo/public/cpp/system/clean_up_stamp
> Traceback (most recent call last):
>   File "../../build/rmdir_and_stamp.py", line 45, in <module>
>     sys.exit(Main(sys.argv[1], sys.argv[2]))
>   File "../../build/rmdir_and_stamp.py", line 40, in Main
>     raise e
> OSError: [Errno 20] Not a directory: 'libsystem.dylib'

OK. It looks like rmdir_and_stamp.py is unused anyways, so you could just delete
it instead :).

[commit-bot: I haz the power, 2016-09-23 21:34:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:34:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Nico, 2016-09-23 21:34:31]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:35:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:43:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 22:48:11]

Description was changed from

==========
Unbreak mac component build.

Components named "system" shadow /usr/lib/libSystem.dylib on OS X.
Give the component a different output name, and also add an action for
a while that cleans up libsystem.dylib from existing build dirs.

BUG=649696
==========

to

==========
Unbreak mac component build.

Components named "system" shadow /usr/lib/libSystem.dylib on OS X.
Give the component a different output name, and also add an action for
a while that cleans up libsystem.dylib from existing build dirs.

BUG=649696

Committed: https://crrev.com/0dfb6ba0b31eae8c8d2aab54ece37bb9ae29e9ea
Cr-Commit-Position: refs/heads/master@{#420752}
==========

[commit-bot: I haz the power, 2016-09-23 22:48:12]

Patchset 1 (id:??) landed as
https://crrev.com/0dfb6ba0b31eae8c8d2aab54ece37bb9ae29e9ea
Cr-Commit-Position: refs/heads/master@{#420752}