third_party/WebKit/Source/core/svg/SVGElement.h - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.h b/third_party/WebKit/Source/core/svg/SVGElement.h

index a7c22972849df01174a80cba4ae6f9db8dea48cc..22e55905ac1d349cdf4903fc9daa3bd3a6efde4d 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGElement.h

@@ -58,7 +58,7 @@ class CORE_EXPORT SVGElement : public Element {

void attachLayoutTree(const AttachContext&) override;

void detachLayoutTree(const AttachContext&) override;

- short tabIndex() const override;

+ int tabIndex() const override;

bool supportsFocus() const override { return false; }

bool isOutermostSVGSVGElement() const;