Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/core/dom/ElementRareData.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ElementRareData.h
diff --git a/third_party/WebKit/Source/core/dom/ElementRareData.h b/third_party/WebKit/Source/core/dom/ElementRareData.h
index 223da50f8dbd5322e8d99d8ddb9616e5c69d3295..eea2372fbae2df2614f6496302ba75692f61fc11 100644
--- a/third_party/WebKit/Source/core/dom/ElementRareData.h
+++ b/third_party/WebKit/Source/core/dom/ElementRareData.h
@@ -60,15 +60,11 @@ class ElementRareData : public NodeRareData {
void setPseudoElement(PseudoId, PseudoElement*);
PseudoElement* pseudoElement(PseudoId) const;
- short tabIndex() const { return m_tabindex; }
-
- void setTabIndexExplicitly(short index) {
- m_tabindex = index;
+ void setTabIndexExplicitly() {
setElementFlag(TabIndexWasSetExplicitly, true);
}
void clearTabIndexExplicitly() {
- m_tabindex = 0;
clearElementFlag(TabIndexWasSetExplicitly);
}
@@ -192,8 +188,6 @@ class ElementRareData : public NodeRareData {
CompositorProxiedPropertySet& ensureCompositorProxiedPropertySet();
void clearCompositorProxiedPropertySet() { m_proxiedProperties = nullptr; }
- short m_tabindex;
-
LayoutSize m_minimumSizeForResizing;
ScrollOffset m_savedLayerScrollOffset;
@@ -226,7 +220,6 @@ inline LayoutSize defaultMinimumSizeForResizing() {
inline ElementRareData::ElementRareData(LayoutObject* layoutObject)
: NodeRareData(layoutObject),
- m_tabindex(0),
m_minimumSizeForResizing(defaultMinimumSizeForResizing()),
m_classList(nullptr) {
m_isElementRareData = true;
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/ElementRareData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698