Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.h
diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h
index ae22bda3cf54494f3a71e79464e4a1ae51b5a17f..ba2fd82cb0395d9d890ffe824fec400cf3f59792 100644
--- a/third_party/WebKit/Source/core/dom/Element.h
+++ b/third_party/WebKit/Source/core/dom/Element.h
@@ -685,7 +685,7 @@ class CORE_EXPORT Element : public ContainerNode {
void clearMutableInlineStyleIfEmpty();
void setTabIndex(int);
- short tabIndex() const override;
+ int tabIndex() const override;
// A compositor proxy is a very limited wrapper around an element. It
// exposes only those properties that are requested at the time the proxy is
@@ -765,7 +765,7 @@ class CORE_EXPORT Element : public ContainerNode {
bool supportsSpatialNavigationFocus() const;
void clearTabIndexExplicitlyIfNeeded();
- void setTabIndexExplicitly(short);
+ void setTabIndexExplicitly();
// Subclasses may override this method to affect focusability. This method
// must be called on an up-to-date ComputedStyle, so it may use existence of
// layoutObject and the LayoutObject::style() to reason about focusability.

Powered by Google App Engine
This is Rietveld 408576698