Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt
diff --git a/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt
index 63daa3851698e05503cd1e5fa33a9b1cedfb9a48..004c7eb06d02e5502a22dd73e42ebbbccca6b626 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt
+++ b/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp-expected.txt
@@ -1,35 +1,38 @@
-This page tests that the tabindex attribute is clamped to values between -32768 and 32767. Values outside of this range should be clamped to the range limits.
+This page tests that the tabindex attribute is accepted for values between -2147483648 and 2147483647. Values outside of this range will make the tabIndex reflected value zero.
-
Testing input elements in the page
-getAttribute("tabindex") = 40000; tabIndex = 32767
-getAttribute("tabindex") = 32768; tabIndex = 32767
-getAttribute("tabindex") = 32767; tabIndex = 32767
-getAttribute("tabindex") = 32766; tabIndex = 32766
+getAttribute("tabindex") = 3147483648; tabIndex = 0
+getAttribute("tabindex") = 2147483648; tabIndex = 0
+getAttribute("tabindex") = 2147483647; tabIndex = 2147483647
+getAttribute("tabindex") = 2147483646; tabIndex = 2147483646
getAttribute("tabindex") = 0; tabIndex = 0
getAttribute("tabindex") = -1; tabIndex = -1
-getAttribute("tabindex") = -32767; tabIndex = -32767
-getAttribute("tabindex") = -32768; tabIndex = -32768
-getAttribute("tabindex") = -32769; tabIndex = -32768
-getAttribute("tabindex") = -40000; tabIndex = -32768
+getAttribute("tabindex") = -2147483647; tabIndex = -2147483647
+getAttribute("tabindex") = -2147483648; tabIndex = -2147483648
+getAttribute("tabindex") = -2147483649; tabIndex = 0
+getAttribute("tabindex") = -3147483648; tabIndex = 0
Testing setAttribute on an anchor element made with document.createElement
-getAttribute("tabindex") = 40000; tabIndex = 32767
-getAttribute("tabindex") = 32768; tabIndex = 32767
-getAttribute("tabindex") = 32767; tabIndex = 32767
-getAttribute("tabindex") = 32766; tabIndex = 32766
+getAttribute("tabindex") = 3147483648; tabIndex = 0
+getAttribute("tabindex") = 2147483648; tabIndex = 0
+getAttribute("tabindex") = 2147483647; tabIndex = 2147483647
+getAttribute("tabindex") = 2147483646; tabIndex = 2147483646
getAttribute("tabindex") = 0; tabIndex = 0
getAttribute("tabindex") = -1; tabIndex = -1
-getAttribute("tabindex") = -32767; tabIndex = -32767
-getAttribute("tabindex") = -32768; tabIndex = -32768
-getAttribute("tabindex") = -40000; tabIndex = -32768
+getAttribute("tabindex") = -2147483647; tabIndex = -2147483647
+getAttribute("tabindex") = -2147483648; tabIndex = -2147483648
+getAttribute("tabindex") = -3147483648; tabIndex = 0
+getAttribute("tabindex") = ; tabIndex = 0
+getAttribute("tabindex") = foo; tabIndex = 0
Testing tabIndex on an area element made with document.createElement
-getAttribute("tabindex") = 40000; tabIndex = 32767
-getAttribute("tabindex") = 32768; tabIndex = 32767
-getAttribute("tabindex") = 32767; tabIndex = 32767
-getAttribute("tabindex") = 32766; tabIndex = 32766
+getAttribute("tabindex") = -1147483648; tabIndex = -1147483648
+getAttribute("tabindex") = -2147483648; tabIndex = -2147483648
+getAttribute("tabindex") = 2147483647; tabIndex = 2147483647
+getAttribute("tabindex") = 2147483646; tabIndex = 2147483646
getAttribute("tabindex") = 0; tabIndex = 0
getAttribute("tabindex") = -1; tabIndex = -1
-getAttribute("tabindex") = -32767; tabIndex = -32767
-getAttribute("tabindex") = -32768; tabIndex = -32768
-getAttribute("tabindex") = -40000; tabIndex = -32768
+getAttribute("tabindex") = -2147483647; tabIndex = -2147483647
+getAttribute("tabindex") = -2147483648; tabIndex = -2147483648
+getAttribute("tabindex") = 1147483648; tabIndex = 1147483648
+getAttribute("tabindex") = 0; tabIndex = 0
+getAttribute("tabindex") = 0; tabIndex = 0

Powered by Google App Engine
This is Rietveld 408576698