Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/dom/ElementRareData.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ElementRareData.h
diff --git a/third_party/WebKit/Source/core/dom/ElementRareData.h b/third_party/WebKit/Source/core/dom/ElementRareData.h
index 9235d629c24a72f9bf0c4ecd95925d027aa98c02..5332fd06c14d2e2a817510260f3a0efe51acf7d5 100644
--- a/third_party/WebKit/Source/core/dom/ElementRareData.h
+++ b/third_party/WebKit/Source/core/dom/ElementRareData.h
@@ -61,9 +61,9 @@ class ElementRareData : public NodeRareData {
void setPseudoElement(PseudoId, PseudoElement*);
PseudoElement* pseudoElement(PseudoId) const;
- short tabIndex() const { return m_tabindex; }
+ int tabIndex() const { return m_tabindex; }
- void setTabIndexExplicitly(short index) {
+ void setTabIndexExplicitly(int index) {
m_tabindex = index;
setElementFlag(TabIndexWasSetExplicitly, true);
}
@@ -181,7 +181,7 @@ class ElementRareData : public NodeRareData {
CompositorProxiedPropertySet& ensureCompositorProxiedPropertySet();
void clearCompositorProxiedPropertySet() { m_proxiedProperties = nullptr; }
- short m_tabindex;
+ int m_tabindex;
LayoutSize m_minimumSizeForResizing;
ScrollOffset m_savedLayerScrollOffset;

Powered by Google App Engine
This is Rietveld 408576698