Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 if (SVGElement* element = correspondingElement()) 81 if (SVGElement* element = correspondingElement())
82 element->removeInstanceMapping(this); 82 element->removeInstanceMapping(this);
83 } 83 }
84 84
85 void SVGElement::attachLayoutTree(const AttachContext& context) { 85 void SVGElement::attachLayoutTree(const AttachContext& context) {
86 Element::attachLayoutTree(context); 86 Element::attachLayoutTree(context);
87 if (SVGElement* element = correspondingElement()) 87 if (SVGElement* element = correspondingElement())
88 element->mapInstanceToElement(this); 88 element->mapInstanceToElement(this);
89 } 89 }
90 90
91 short SVGElement::tabIndex() const { 91 int SVGElement::tabIndex() const {
92 if (supportsFocus()) 92 if (supportsFocus())
93 return Element::tabIndex(); 93 return Element::tabIndex();
94 return -1; 94 return -1;
95 } 95 }
96 96
97 void SVGElement::willRecalcStyle(StyleRecalcChange change) { 97 void SVGElement::willRecalcStyle(StyleRecalcChange change) {
98 if (!hasSVGRareData()) 98 if (!hasSVGRareData())
99 return; 99 return;
100 // If the style changes because of a regular property change (not induced by 100 // If the style changes because of a regular property change (not induced by
101 // SMIL animations themselves) reset the "computed style without SMIL style 101 // SMIL animations themselves) reset the "computed style without SMIL style
(...skipping 1127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 visitor->trace(m_className); 1229 visitor->trace(m_className);
1230 Element::trace(visitor); 1230 Element::trace(visitor);
1231 } 1231 }
1232 1232
1233 const AtomicString& SVGElement::eventParameterName() { 1233 const AtomicString& SVGElement::eventParameterName() {
1234 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1234 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1235 return evtString; 1235 return evtString;
1236 } 1236 }
1237 1237
1238 } // namespace blink 1238 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698