Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 &document(), ResourceRequest(document().completeURL(url)), target); 139 &document(), ResourceRequest(document().completeURL(url)), target);
140 frameRequest.setTriggeringEvent(event); 140 frameRequest.setTriggeringEvent(event);
141 frame->loader().load(frameRequest); 141 frame->loader().load(frameRequest);
142 return; 142 return;
143 } 143 }
144 } 144 }
145 145
146 SVGGraphicsElement::defaultEventHandler(event); 146 SVGGraphicsElement::defaultEventHandler(event);
147 } 147 }
148 148
149 short SVGAElement::tabIndex() const { 149 int SVGAElement::tabIndex() const {
150 // Skip the supportsFocus check in SVGElement. 150 // Skip the supportsFocus check in SVGElement.
151 return Element::tabIndex(); 151 return Element::tabIndex();
152 } 152 }
153 153
154 bool SVGAElement::supportsFocus() const { 154 bool SVGAElement::supportsFocus() const {
155 if (hasEditableStyle(*this)) 155 if (hasEditableStyle(*this))
156 return SVGGraphicsElement::supportsFocus(); 156 return SVGGraphicsElement::supportsFocus();
157 // If not a link we should still be able to focus the element if it has 157 // If not a link we should still be able to focus the element if it has
158 // tabIndex. 158 // tabIndex.
159 return isLink() || SVGGraphicsElement::supportsFocus(); 159 return isLink() || SVGGraphicsElement::supportsFocus();
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 if (!isLink()) 209 if (!isLink())
210 return SVGElement::canStartSelection(); 210 return SVGElement::canStartSelection();
211 return hasEditableStyle(*this); 211 return hasEditableStyle(*this);
212 } 212 }
213 213
214 bool SVGAElement::willRespondToMouseClickEvents() { 214 bool SVGAElement::willRespondToMouseClickEvents() {
215 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents(); 215 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents();
216 } 216 }
217 217
218 } // namespace blink 218 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAElement.h ('k') | third_party/WebKit/Source/core/svg/SVGElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698