Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 } 348 }
349 349
350 bool HTMLSlotElement::findHostChildWithSameSlotName() const { 350 bool HTMLSlotElement::findHostChildWithSameSlotName() const {
351 ShadowRoot* root = containingShadowRoot(); 351 ShadowRoot* root = containingShadowRoot();
352 DCHECK(root); 352 DCHECK(root);
353 DCHECK(root->isV1()); 353 DCHECK(root->isV1());
354 SlotAssignment& assignment = root->ensureSlotAssignment(); 354 SlotAssignment& assignment = root->ensureSlotAssignment();
355 return assignment.findHostChildBySlotName(name()); 355 return assignment.findHostChildBySlotName(name());
356 } 356 }
357 357
358 short HTMLSlotElement::tabIndex() const { 358 int HTMLSlotElement::tabIndex() const {
359 return Element::tabIndex(); 359 return Element::tabIndex();
360 } 360 }
361 361
362 DEFINE_TRACE(HTMLSlotElement) { 362 DEFINE_TRACE(HTMLSlotElement) {
363 visitor->trace(m_assignedNodes); 363 visitor->trace(m_assignedNodes);
364 visitor->trace(m_distributedNodes); 364 visitor->trace(m_distributedNodes);
365 visitor->trace(m_oldDistributedNodes); 365 visitor->trace(m_oldDistributedNodes);
366 visitor->trace(m_distributedIndices); 366 visitor->trace(m_distributedIndices);
367 HTMLElement::trace(visitor); 367 HTMLElement::trace(visitor);
368 } 368 }
369 369
370 } // namespace blink 370 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSlotElement.h ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698