Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 void HTMLOutputElement::setDefaultValue(const String& value) { 123 void HTMLOutputElement::setDefaultValue(const String& value) {
124 if (m_defaultValue == value) 124 if (m_defaultValue == value)
125 return; 125 return;
126 m_defaultValue = value; 126 m_defaultValue = value;
127 // The spec requires the value attribute set to the default value 127 // The spec requires the value attribute set to the default value
128 // when the element's value mode flag to "default". 128 // when the element's value mode flag to "default".
129 if (m_isDefaultValueMode) 129 if (m_isDefaultValueMode)
130 setTextContent(value); 130 setTextContent(value);
131 } 131 }
132 132
133 short HTMLOutputElement::tabIndex() const { 133 int HTMLOutputElement::tabIndex() const {
134 return HTMLElement::tabIndex(); 134 return HTMLElement::tabIndex();
135 } 135 }
136 136
137 DEFINE_TRACE(HTMLOutputElement) { 137 DEFINE_TRACE(HTMLOutputElement) {
138 visitor->trace(m_tokens); 138 visitor->trace(m_tokens);
139 HTMLFormControlElement::trace(visitor); 139 HTMLFormControlElement::trace(visitor);
140 DOMTokenListObserver::trace(visitor); 140 DOMTokenListObserver::trace(visitor);
141 } 141 }
142 142
143 } // namespace blink 143 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOutputElement.h ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698