Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 void setNeedsWillValidateCheck(); 162 void setNeedsWillValidateCheck();
163 virtual bool recalcWillValidate() const; 163 virtual bool recalcWillValidate() const;
164 164
165 virtual void resetImpl() {} 165 virtual void resetImpl() {}
166 virtual bool supportsAutofocus() const; 166 virtual bool supportsAutofocus() const;
167 167
168 private: 168 private:
169 bool isFormControlElement() const final { return true; } 169 bool isFormControlElement() const final { return true; }
170 bool alwaysCreateUserAgentShadowRoot() const override { return true; } 170 bool alwaysCreateUserAgentShadowRoot() const override { return true; }
171 171
172 short tabIndex() const; 172 int tabIndex() const;
173 173
174 bool isValidElement() override; 174 bool isValidElement() override;
175 bool matchesValidityPseudoClasses() const override; 175 bool matchesValidityPseudoClasses() const override;
176 void updateAncestorDisabledState() const; 176 void updateAncestorDisabledState() const;
177 177
178 bool isValidationMessageVisible() const; 178 bool isValidationMessageVisible() const;
179 ValidationMessageClient* validationMessageClient() const; 179 ValidationMessageClient* validationMessageClient() const;
180 180
181 // Requests validity recalc for the form owner, if one exists. 181 // Requests validity recalc for the form owner, if one exists.
182 void formOwnerSetNeedsValidityCheck(); 182 void formOwnerSetNeedsValidityCheck();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement); 214 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
215 DEFINE_TYPE_CASTS(HTMLFormControlElement, 215 DEFINE_TYPE_CASTS(HTMLFormControlElement,
216 FormAssociatedElement, 216 FormAssociatedElement,
217 control, 217 control,
218 control->isFormControlElement(), 218 control->isFormControlElement(),
219 control.isFormControlElement()); 219 control.isFormControlElement());
220 220
221 } // namespace blink 221 } // namespace blink
222 222
223 #endif 223 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698