Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 383
384 // Change of m_wasFocusByMouse may affect shouldHaveFocusAppearance() and 384 // Change of m_wasFocusByMouse may affect shouldHaveFocusAppearance() and
385 // LayoutTheme::isFocused(). Inform LayoutTheme if 385 // LayoutTheme::isFocused(). Inform LayoutTheme if
386 // shouldHaveFocusAppearance() changes. 386 // shouldHaveFocusAppearance() changes.
387 if (oldShouldHaveFocusAppearance != shouldHaveFocusAppearance() && 387 if (oldShouldHaveFocusAppearance != shouldHaveFocusAppearance() &&
388 layoutObject()) 388 layoutObject())
389 LayoutTheme::theme().controlStateChanged(*layoutObject(), 389 LayoutTheme::theme().controlStateChanged(*layoutObject(),
390 FocusControlState); 390 FocusControlState);
391 } 391 }
392 392
393 short HTMLFormControlElement::tabIndex() const { 393 int HTMLFormControlElement::tabIndex() const {
394 // Skip the supportsFocus check in HTMLElement. 394 // Skip the supportsFocus check in HTMLElement.
395 return Element::tabIndex(); 395 return Element::tabIndex();
396 } 396 }
397 397
398 bool HTMLFormControlElement::recalcWillValidate() const { 398 bool HTMLFormControlElement::recalcWillValidate() const {
399 if (m_dataListAncestorState == Unknown) { 399 if (m_dataListAncestorState == Unknown) {
400 if (Traversal<HTMLDataListElement>::firstAncestor(*this)) 400 if (Traversal<HTMLDataListElement>::firstAncestor(*this))
401 m_dataListAncestorState = InsideDataList; 401 m_dataListAncestorState = InsideDataList;
402 else 402 else
403 m_dataListAncestorState = NotInsideDataList; 403 m_dataListAncestorState = NotInsideDataList;
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 return trimmedName; 621 return trimmedName;
622 } 622 }
623 623
624 void HTMLFormControlElement::copyNonAttributePropertiesFromElement( 624 void HTMLFormControlElement::copyNonAttributePropertiesFromElement(
625 const Element& source) { 625 const Element& source) {
626 HTMLElement::copyNonAttributePropertiesFromElement(source); 626 HTMLElement::copyNonAttributePropertiesFromElement(source);
627 setNeedsValidityCheck(); 627 setNeedsValidityCheck();
628 } 628 }
629 629
630 } // namespace blink 630 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormControlElement.h ('k') | third_party/WebKit/Source/core/html/HTMLOutputElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698