Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 DEFINE_WRAPPERTYPEINFO(); 44 DEFINE_WRAPPERTYPEINFO();
45 45
46 public: 46 public:
47 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLElement); 47 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLElement);
48 48
49 bool hasTagName(const HTMLQualifiedName& name) const { 49 bool hasTagName(const HTMLQualifiedName& name) const {
50 return hasLocalName(name.localName()); 50 return hasLocalName(name.localName());
51 } 51 }
52 52
53 String title() const final; 53 String title() const final;
54 short tabIndex() const override; 54 int tabIndex() const override;
55 55
56 void setInnerText(const String&, ExceptionState&); 56 void setInnerText(const String&, ExceptionState&);
57 void setOuterText(const String&, ExceptionState&); 57 void setOuterText(const String&, ExceptionState&);
58 58
59 virtual bool hasCustomFocusLogic() const; 59 virtual bool hasCustomFocusLogic() const;
60 60
61 String contentEditable() const; 61 String contentEditable() const;
62 void setContentEditable(const String&, ExceptionState&); 62 void setContentEditable(const String&, ExceptionState&);
63 // For HTMLElement.prototype.isContentEditable. This matches to neither 63 // For HTMLElement.prototype.isContentEditable. This matches to neither
64 // blink::isContentEditable() nor blink::isContentRichlyEditable(). Do not 64 // blink::isContentEditable() nor blink::isContentRichlyEditable(). Do not
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 inline bool isElementOfType<const thisType>(const HTMLElement& element) { \ 231 inline bool isElementOfType<const thisType>(const HTMLElement& element) { \
232 return is##thisType(element); \ 232 return is##thisType(element); \
233 } \ 233 } \
234 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 234 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
235 235
236 } // namespace blink 236 } // namespace blink
237 237
238 #include "core/HTMLElementTypeHelpers.h" 238 #include "core/HTMLElementTypeHelpers.h"
239 239
240 #endif // HTMLElement_h 240 #endif // HTMLElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698