Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 WebFocusType, 110 WebFocusType,
111 InputDeviceCapabilities* sourceCapabilities) override; 111 InputDeviceCapabilities* sourceCapabilities) override;
112 bool isMouseFocusable() const override; 112 bool isMouseFocusable() const override;
113 bool isKeyboardFocusable() const override; 113 bool isKeyboardFocusable() const override;
114 void defaultEventHandler(Event*) final; 114 void defaultEventHandler(Event*) final;
115 void setActive(bool = true) final; 115 void setActive(bool = true) final;
116 void accessKeyAction(bool sendMouseEvents) final; 116 void accessKeyAction(bool sendMouseEvents) final;
117 bool isURLAttribute(const Attribute&) const final; 117 bool isURLAttribute(const Attribute&) const final;
118 bool hasLegalLinkAttribute(const QualifiedName&) const final; 118 bool hasLegalLinkAttribute(const QualifiedName&) const final;
119 bool canStartSelection() const final; 119 bool canStartSelection() const final;
120 short tabIndex() const final; 120 int tabIndex() const final;
121 bool draggable() const final; 121 bool draggable() const final;
122 bool isInteractiveContent() const final; 122 bool isInteractiveContent() const final;
123 InsertionNotificationRequest insertedInto(ContainerNode*) override; 123 InsertionNotificationRequest insertedInto(ContainerNode*) override;
124 void handleClick(Event*); 124 void handleClick(Event*);
125 NavigationHintSender* ensureNavigationHintSender(); 125 NavigationHintSender* ensureNavigationHintSender();
126 126
127 uint32_t m_linkRelations; 127 uint32_t m_linkRelations;
128 mutable LinkHash m_cachedVisitedLinkHash; 128 mutable LinkHash m_cachedVisitedLinkHash;
129 bool m_wasFocusedByMouse; 129 bool m_wasFocusedByMouse;
130 Member<NavigationHintSender> m_navigationHintSender; 130 Member<NavigationHintSender> m_navigationHintSender;
131 }; 131 };
132 132
133 inline LinkHash HTMLAnchorElement::visitedLinkHash() const { 133 inline LinkHash HTMLAnchorElement::visitedLinkHash() const {
134 if (!m_cachedVisitedLinkHash) 134 if (!m_cachedVisitedLinkHash)
135 m_cachedVisitedLinkHash = blink::visitedLinkHash( 135 m_cachedVisitedLinkHash = blink::visitedLinkHash(
136 document().baseURL(), fastGetAttribute(HTMLNames::hrefAttr)); 136 document().baseURL(), fastGetAttribute(HTMLNames::hrefAttr));
137 return m_cachedVisitedLinkHash; 137 return m_cachedVisitedLinkHash;
138 } 138 }
139 139
140 // Functions shared with the other anchor elements (i.e., SVG). 140 // Functions shared with the other anchor elements (i.e., SVG).
141 141
142 bool isEnterKeyKeydownEvent(Event*); 142 bool isEnterKeyKeydownEvent(Event*);
143 bool isLinkClick(Event*); 143 bool isLinkClick(Event*);
144 144
145 } // namespace blink 145 } // namespace blink
146 146
147 #endif // HTMLAnchorElement_h 147 #endif // HTMLAnchorElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698