Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 if (newLinkRelations.contains("noreferrer")) 353 if (newLinkRelations.contains("noreferrer"))
354 m_linkRelations |= RelationNoReferrer; 354 m_linkRelations |= RelationNoReferrer;
355 if (newLinkRelations.contains("noopener")) 355 if (newLinkRelations.contains("noopener"))
356 m_linkRelations |= RelationNoOpener; 356 m_linkRelations |= RelationNoOpener;
357 } 357 }
358 358
359 const AtomicString& HTMLAnchorElement::name() const { 359 const AtomicString& HTMLAnchorElement::name() const {
360 return getNameAttribute(); 360 return getNameAttribute();
361 } 361 }
362 362
363 short HTMLAnchorElement::tabIndex() const { 363 int HTMLAnchorElement::tabIndex() const {
364 // Skip the supportsFocus check in HTMLElement. 364 // Skip the supportsFocus check in HTMLElement.
365 return Element::tabIndex(); 365 return Element::tabIndex();
366 } 366 }
367 367
368 bool HTMLAnchorElement::isLiveLink() const { 368 bool HTMLAnchorElement::isLiveLink() const {
369 return isLink() && !hasEditableStyle(*this); 369 return isLink() && !hasEditableStyle(*this);
370 } 370 }
371 371
372 void HTMLAnchorElement::sendPings(const KURL& destinationURL) const { 372 void HTMLAnchorElement::sendPings(const KURL& destinationURL) const {
373 const AtomicString& pingValue = getAttribute(pingAttr); 373 const AtomicString& pingValue = getAttribute(pingAttr);
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 } 474 }
475 475
476 HTMLAnchorElement::NavigationHintSender* 476 HTMLAnchorElement::NavigationHintSender*
477 HTMLAnchorElement::ensureNavigationHintSender() { 477 HTMLAnchorElement::ensureNavigationHintSender() {
478 if (!m_navigationHintSender) 478 if (!m_navigationHintSender)
479 m_navigationHintSender = NavigationHintSender::create(this); 479 m_navigationHintSender = NavigationHintSender::create(this);
480 return m_navigationHintSender; 480 return m_navigationHintSender;
481 } 481 }
482 482
483 } // namespace blink 483 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.h ('k') | third_party/WebKit/Source/core/html/HTMLElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698