Stop clamping tabIndex to short range

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
  * All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
@@ skipping 198 matching lines @@
   if (!hasRareData())
     return;
   elementRareData()->clearElementFlag(mask);
 }
 
 void Element::clearTabIndexExplicitlyIfNeeded() {
   if (hasRareData())
     elementRareData()->clearTabIndexExplicitly();
 }
 
-void Element::setTabIndexExplicitly(short tabIndex) {
-  ensureElementRareData().setTabIndexExplicitly(tabIndex);
+void Element::setTabIndexExplicitly() {
+  ensureElementRareData().setTabIndexExplicitly();
 }
 
 void Element::setTabIndex(int value) {
   setIntegralAttribute(tabindexAttr, value);
 }
 
-short Element::tabIndex() const {
-  return hasRareData() ? elementRareData()->tabIndex() : 0;
+int Element::tabIndex() const {
+  return hasElementFlag(TabIndexWasSetExplicitly)
+             ? getIntegralAttribute(tabindexAttr)
+             : 0;
 }
 
 bool Element::layoutObjectIsFocusable() const {
   // Elements in canvas fallback content are not rendered, but they are allowed
   // to be focusable as long as their canvas is displayed and visible.
   if (isInCanvasSubtree()) {
     const HTMLCanvasElement* canvas =
         Traversal<HTMLCanvasElement>::firstAncestorOrSelf(*this);
     DCHECK(canvas);
     return canvas->layoutObject() &&
@@ skipping 2191 matching lines @@
 
   detachAttrNodeAtIndex(attr, index);
   return attr;
 }
 
 void Element::parseAttribute(const QualifiedName& name,
                              const AtomicString&,
                              const AtomicString& value) {
   if (name == tabindexAttr) {
     int tabindex = 0;
-    if (value.isEmpty()) {
+    if (value.isEmpty() || !parseHTMLInteger(value, tabindex)) {
       clearTabIndexExplicitlyIfNeeded();
       if (adjustedFocusedElementInTreeScope() == this) {
         // We might want to call blur(), but it's dangerous to dispatch
         // events here.
         document().setNeedsFocusedElementCheck();
       }
-    } else if (parseHTMLInteger(value, tabindex)) {
-      // Clamp tabindex to the range of 'short' to match Firefox's behavior.
-      setTabIndexExplicitly(
-          max(static_cast<int>(std::numeric_limits<short>::min()),
-              std::min(tabindex,
-                       static_cast<int>(std::numeric_limits<short>::max()))));
+    } else {
+      // We only set when value is in integer range.
+      setTabIndexExplicitly();
     }
   } else if (name == XMLNames::langAttr) {
     pseudoStateChanged(CSSSelector::PseudoLang);
   }
 }
 
 bool Element::parseAttributeName(QualifiedName& out,
                                  const AtomicString& namespaceURI,
                                  const AtomicString& qualifiedName,
                                  ExceptionState& exceptionState) {
@@ skipping 1626 matching lines @@
 }
 
 DEFINE_TRACE_WRAPPERS(Element) {
   if (hasRareData()) {
     visitor->traceWrappers(elementRareData());
   }
   ContainerNode::traceWrappers(visitor);
 }
 
 }  // namespace blink