Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 typedef HeapHashSet<Member<SVGElement>> SVGElementSet; 52 typedef HeapHashSet<Member<SVGElement>> SVGElementSet;
53 53
54 class CORE_EXPORT SVGElement : public Element { 54 class CORE_EXPORT SVGElement : public Element {
55 DEFINE_WRAPPERTYPEINFO(); 55 DEFINE_WRAPPERTYPEINFO();
56 56
57 public: 57 public:
58 ~SVGElement() override; 58 ~SVGElement() override;
59 void attachLayoutTree(const AttachContext&) override; 59 void attachLayoutTree(const AttachContext&) override;
60 void detachLayoutTree(const AttachContext&) override; 60 void detachLayoutTree(const AttachContext&) override;
61 61
62 short tabIndex() const override; 62 int tabIndex() const override;
63 bool supportsFocus() const override { return false; } 63 bool supportsFocus() const override { return false; }
64 64
65 bool isOutermostSVGSVGElement() const; 65 bool isOutermostSVGSVGElement() const;
66 66
67 bool hasTagName(const SVGQualifiedName& name) const { 67 bool hasTagName(const SVGQualifiedName& name) const {
68 return hasLocalName(name.localName()); 68 return hasLocalName(name.localName());
69 } 69 }
70 70
71 String title() const override; 71 String title() const override;
72 bool hasRelativeLengths() const { 72 bool hasRelativeLengths() const {
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 inline bool isElementOfType<const thisType>(const SVGElement& element) { \ 344 inline bool isElementOfType<const thisType>(const SVGElement& element) { \
345 return is##thisType(element); \ 345 return is##thisType(element); \
346 } \ 346 } \
347 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 347 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
348 348
349 } // namespace blink 349 } // namespace blink
350 350
351 #include "core/SVGElementTypeHelpers.h" 351 #include "core/SVGElementTypeHelpers.h"
352 352
353 #endif // SVGElement_h 353 #endif // SVGElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698