Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 &document(), ResourceRequest(document().completeURL(url)), target); 141 &document(), ResourceRequest(document().completeURL(url)), target);
142 frameRequest.setTriggeringEvent(event); 142 frameRequest.setTriggeringEvent(event);
143 frame->loader().load(frameRequest); 143 frame->loader().load(frameRequest);
144 return; 144 return;
145 } 145 }
146 } 146 }
147 147
148 SVGGraphicsElement::defaultEventHandler(event); 148 SVGGraphicsElement::defaultEventHandler(event);
149 } 149 }
150 150
151 short SVGAElement::tabIndex() const { 151 int SVGAElement::tabIndex() const {
152 // Skip the supportsFocus check in SVGElement. 152 // Skip the supportsFocus check in SVGElement.
153 return Element::tabIndex(); 153 return Element::tabIndex();
154 } 154 }
155 155
156 bool SVGAElement::supportsFocus() const { 156 bool SVGAElement::supportsFocus() const {
157 if (hasEditableStyle(*this)) 157 if (hasEditableStyle(*this))
158 return SVGGraphicsElement::supportsFocus(); 158 return SVGGraphicsElement::supportsFocus();
159 // If not a link we should still be able to focus the element if it has 159 // If not a link we should still be able to focus the element if it has
160 // tabIndex. 160 // tabIndex.
161 return isLink() || SVGGraphicsElement::supportsFocus(); 161 return isLink() || SVGGraphicsElement::supportsFocus();
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 if (!isLink()) 211 if (!isLink())
212 return SVGElement::canStartSelection(); 212 return SVGElement::canStartSelection();
213 return hasEditableStyle(*this); 213 return hasEditableStyle(*this);
214 } 214 }
215 215
216 bool SVGAElement::willRespondToMouseClickEvents() { 216 bool SVGAElement::willRespondToMouseClickEvents() {
217 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents(); 217 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents();
218 } 218 }
219 219
220 } // namespace blink 220 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698