Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 void lazyReattachDistributedNodesIfNeeded(); 72 void lazyReattachDistributedNodesIfNeeded();
73 73
74 void attachLayoutTree(const AttachContext& = AttachContext()) final; 74 void attachLayoutTree(const AttachContext& = AttachContext()) final;
75 void detachLayoutTree(const AttachContext& = AttachContext()) final; 75 void detachLayoutTree(const AttachContext& = AttachContext()) final;
76 76
77 void attributeChanged(const QualifiedName&, 77 void attributeChanged(const QualifiedName&,
78 const AtomicString& oldValue, 78 const AtomicString& oldValue,
79 const AtomicString& newValue, 79 const AtomicString& newValue,
80 AttributeModificationReason = ModifiedDirectly) final; 80 AttributeModificationReason = ModifiedDirectly) final;
81 81
82 short tabIndex() const override; 82 int tabIndex() const override;
83 AtomicString name() const; 83 AtomicString name() const;
84 84
85 // This method can be slow because this has to traverse the children of a 85 // This method can be slow because this has to traverse the children of a
86 // shadow host. This method should be used only when m_assignedNodes is 86 // shadow host. This method should be used only when m_assignedNodes is
87 // dirty. e.g. To detect a slotchange event in DOM mutations. 87 // dirty. e.g. To detect a slotchange event in DOM mutations.
88 bool hasAssignedNodesSlow() const; 88 bool hasAssignedNodesSlow() const;
89 bool findHostChildWithSameSlotName() const; 89 bool findHostChildWithSameSlotName() const;
90 90
91 void enqueueSlotChangeEvent(); 91 void enqueueSlotChangeEvent();
92 92
(...skipping 16 matching lines...) Expand all
109 HeapVector<Member<Node>> m_assignedNodes; 109 HeapVector<Member<Node>> m_assignedNodes;
110 HeapVector<Member<Node>> m_distributedNodes; 110 HeapVector<Member<Node>> m_distributedNodes;
111 HeapVector<Member<Node>> m_oldDistributedNodes; 111 HeapVector<Member<Node>> m_oldDistributedNodes;
112 HeapHashMap<Member<const Node>, size_t> m_distributedIndices; 112 HeapHashMap<Member<const Node>, size_t> m_distributedIndices;
113 bool m_slotchangeEventEnqueued = false; 113 bool m_slotchangeEventEnqueued = false;
114 }; 114 };
115 115
116 } // namespace blink 116 } // namespace blink
117 117
118 #endif // HTMLSlotElement_h 118 #endif // HTMLSlotElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698